Bug 223915 - Address post-commit comments on r275180
Summary: Address post-commit comments on r275180
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-30 01:15 PDT by Myles C. Maxfield
Modified: 2021-03-30 15:02 PDT (History)
2 users (show)

See Also:

Attachments
Patch (11.50 KB, patch)
2021-03-30 01:15 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2021-03-30 01:15:10 PDT 
Address post-review comments on r275180
Comment 1 Myles C. Maxfield 2021-03-30 01:15:45 PDT 
Created attachment 424620 [details]
Patch
Comment 2 Kimmo Kinnunen 2021-03-30 01:21:37 PDT 
Comment on attachment 424620 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424620&action=review

> Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:184
> +    return m_getImageDataSemaphore->waitFor(timeout.secondsUntilDeadline());

waitFor(timeout)
Comment 3 Myles C. Maxfield 2021-03-30 15:01:49 PDT 
Committed r275240 (235930@main): <https://commits.webkit.org/235930@main>
Comment 4 Radar WebKit Bug Importer 2021-03-30 15:02:39 PDT 
<rdar://problem/76023839>