Bug 223912 – Allow non-60fps display updates to be driven by DisplayRefreshMonitor

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Simon Fraser (smfr)]

Allow non-60fps display updates to be driven by DisplayRefreshMonitor

[Simon Fraser (smfr)]

Created attachment 424616 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/76004517>

[Sam Weinig]

Comment on attachment 424616 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424616&action=review

Love the tests!

> Source/WebCore/ChangeLog:21
> +        Also add preferredFramesPerSecond() to use here, and have both it and

I'm unclear what "here" is in this context.

> Source/WebCore/page/Page.cpp:1201
>      renderingUpdateScheduler().windowScreenDidChange(displayID);
> +    renderingUpdateScheduler().adjustRenderingUpdateFrequency();

I would either pull renderingUpdateScheduler into a local (since the getter does work) or just have windowScreenDidChange() call adjustRenderingUpdateFrequency(),

> Source/WebCore/page/Page.h:429
> +    // This can return nullopt if throttling reasons result in a frequency less than one, in which case
> +    // preferredRenderingUpdateInterval provides the frequency.
> +    Optional<FramesPerSecond> preferredRenderingUpdateFramesPerSecond() const;

This seems a little silly that two calls are needed. In the future, we should we consider making FramesPerSecond be a struct containing a ratio that can represent frequencies less than one, or make this return a Variant<FramesPerSecond, Seconds>.

> Source/WebCore/platform/Logging.cpp:95
> +    LogRequestAnimationFrame.state = WTFLogChannelState::On;
> +    LogDisplayLink.state = WTFLogChannelState::On;

Did you mean to leave these in?

> Source/WebCore/platform/graphics/AnimationFrameRate.cpp:33
> +static constexpr OptionSet<ThrottlingReason> halfSpeedThrottlingReasons = { ThrottlingReason::LowPowerMode, ThrottlingReason::NonInteractedCrossOriginFrame, ThrottlingReason::VisuallyIdle };

I don't think the `=` is needed here.

[Simon Fraser (smfr)]

https://trac.webkit.org/changeset/275215/webkit