Bug 223884 – Reduce bytecode instruction count emitted for `class extends`

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Alexey Shvayka]

Reduce bytecode instruction count emitted for `class extends`

[Alexey Shvayka]

Created attachment 424544 [details]
Patch

[Alexey Shvayka]

Created attachment 424707 [details]
Patch

Fix divots to point to correct location.

[Yusuke Suzuki]

Comment on attachment 424707 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424707&action=review

r=me

> Source/JavaScriptCore/runtime/ExceptionHelpers.cpp:275
> +static String invalidPrototypeSourceAppender(const String& originalMessage, const String& sourceText, RuntimeType, ErrorInstance::SourceTextWhereErrorOccurred occurrence)
> +{
> +    if (occurrence == ErrorInstance::FoundApproximateSource)
> +        return defaultApproximateSourceError(originalMessage, sourceText);
> +
> +    auto extendsIndex = sourceText.reverseFind("extends");
> +    if (extendsIndex == notFound || sourceText.find("extends") != extendsIndex)
> +        return makeString(originalMessage, " (evaluating '", sourceText, "')");
> +
> +    return "The value of the superclass's prototype property is not an object or null."_s;
> +}

This is awesome.

[EWS]

Committed r275439: <https://commits.webkit.org/r275439>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424707 [details].

[Radar WebKit Bug Importer]

<rdar://problem/76165091>