Bug 223883 – Remove [Replaceable] extended attribute from `document.all`

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Alexey Shvayka]

Remove [Replaceable] extended attribute from `document.all`

[Alexey Shvayka]

Created attachment 424543 [details]
Patch

[Darin Adler]

Comment on attachment 424543 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424543&action=review

> Source/WebCore/ChangeLog:13
> +        iOS apps should be unaffected as they were authored long after `document.all` time.

What you mean is:

- iOS apps are unlikely to accidentally depend on subtleties in document.all behavior since they were authored long after there was a need,

But this ignores the likelihood that these apps may include very old versions of libraries originally designed for the web. I am optimistic this will not be the case, but I don’t know that we can confidently state that.

[Alexey Shvayka]

Committed r275445 (236106@main): <https://commits.webkit.org/236106@main>

[Alexey Shvayka]

(In reply to Darin Adler from comment #2)

I appreciate the review!

> What you mean is:
> 
> - iOS apps are unlikely to accidentally depend on subtleties in document.all
> behavior since they were authored long after there was a need,

Right, I've tweaked the wording.

> But this ignores the likelihood that these apps may include very old
> versions of libraries originally designed for the web. I am optimistic this
> will not be the case, but I don’t know that we can confidently state that.

I am pretty sure we can state that: `document.all` was introduced in IE4 as a regular IDL attribute; it was never replaceable.
For a legacy web library to be cross-browser, it couldn't depend on `document.all` being reassignable. Updated ChangeLog to mention this.

[Radar WebKit Bug Importer]

<rdar://problem/76167832>