Bug 223882 – [Flatpak SDK] Enable LLVM extension

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Philippe Normand]

The clang shipped by default in the FDO SDK is not usable for ASan, UBSan (and I guess TSan) builds, but the Flatpak extension shipping LLVM11 allows this.

[Philippe Normand]

Created attachment 424630 [details]
Patch

[Adrian Perez]

Comment on attachment 424630 [details]
Patch

Patch LGTM with a couple of small nits :)

View in context: https://bugs.webkit.org/attachment.cgi?id=424630&action=review

> Tools/flatpak/flatpakutils.py:736
> +                building = os.path.basename(args[0]).startswith("build")

This check looks a bit brittle, but other than using “in ("build-webkit", "build-jsc")” to
check for a well-known list of possible build scripts, I don't really have a better idea 🤔️

> Tools/flatpak/flatpakutils.py:988
> +            clang_archive, clang_toolchaines = self.pack_toolchain(("clang", "clang++"), {"/usr/bin/clang++": "clang++",

Typo in variable name: clanf_toolchaines → clang_toolchains

[Philippe Normand]

Comment on attachment 424630 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424630&action=review

>> Tools/flatpak/flatpakutils.py:736
>> +                building = os.path.basename(args[0]).startswith("build")
> 
> This check looks a bit brittle, but other than using “in ("build-webkit", "build-jsc")” to
> check for a well-known list of possible build scripts, I don't really have a better idea 🤔️

There's a is_build_webkit() method already. I could add one for is_build_jsc() as well and then here `building = self.is_build_webkit() or self.is_build_jsc()` wdyt?

[Adrian Perez]

(In reply to Philippe Normand from comment #3)
> Comment on attachment 424630 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=424630&action=review
> 
> >> Tools/flatpak/flatpakutils.py:736
> >> +                building = os.path.basename(args[0]).startswith("build")
> > 
> > This check looks a bit brittle, but other than using “in ("build-webkit", "build-jsc")” to
> > check for a well-known list of possible build scripts, I don't really have a better idea 🤔️
> 
> There's a is_build_webkit() method already. I could add one for
> is_build_jsc() as well and then here `building = self.is_build_webkit() or
> self.is_build_jsc()` wdyt?

This sounds perfect 👍️

[Philippe Normand]

Created attachment 425363 [details]
Patch

[EWS]

Committed r275595: <https://commits.webkit.org/r275595>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425363 [details].

[Radar WebKit Bug Importer]

<rdar://problem/76326393>