Bug 22387 - Add a test for the HTMLOptionsCollection indexed setter
Summary: Add a test for the HTMLOptionsCollection indexed setter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pam Greene (IRC:pamg)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-20 11:44 PST by Pam Greene (IRC:pamg)
Modified: 2008-11-20 15:20 PST (History)
0 users

See Also:


Attachments
New test + result (1.89 KB, patch)
2008-11-20 11:48 PST, Pam Greene (IRC:pamg)
no flags Details | Formatted Diff | Diff
Better new test, checks function-style getter too (2.57 KB, patch)
2008-11-20 13:52 PST, Pam Greene (IRC:pamg)
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pam Greene (IRC:pamg) 2008-11-20 11:44:52 PST
Simple test.
Comment 1 Pam Greene (IRC:pamg) 2008-11-20 11:48:02 PST
Created attachment 25321 [details]
New test + result
Comment 2 Darin Adler 2008-11-20 11:52:02 PST
Comment on attachment 25321 [details]
New test + result

r=me

It's a little sad to have these one-off tests when they could easily be changed to have more coverage. It makes our test suite run a lot faster when individual tests can test more than one closely-related thing.
Comment 3 Pam Greene (IRC:pamg) 2008-11-20 13:52:39 PST
Created attachment 25323 [details]
Better new test, checks function-style getter too

Combining the next one on my list with this one, and using the JS wrapper.  Sorry for the wasted previous review.
Comment 4 Pam Greene (IRC:pamg) 2008-11-20 13:53:28 PST
Comment on attachment 25321 [details]
New test + result

Clearing r+ on obsolete patch.
Comment 5 Darin Adler 2008-11-20 14:07:12 PST
Comment on attachment 25323 [details]
Better new test, checks function-style getter too

r=me
Comment 6 Pam Greene (IRC:pamg) 2008-11-20 15:20:24 PST
Landed in r38633.