RESOLVED FIXED 22387
Add a test for the HTMLOptionsCollection indexed setter 
https://bugs.webkit.org/show_bug.cgi?id=22387
Summary Add a test for the HTMLOptionsCollection indexed setter
Pam Greene (IRC:pamg)
Reported 2008-11-20 11:44:52 PST
Simple test.
Attachments
New test + result (1.89 KB, patch)
2008-11-20 11:48 PST, Pam Greene (IRC:pamg) 		no flags
DetailsFormatted DiffDiff
Better new test, checks function-style getter too (2.57 KB, patch)
2008-11-20 13:52 PST, Pam Greene (IRC:pamg) 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pam Greene (IRC:pamg)
Comment 1 2008-11-20 11:48:02 PST
Created attachment 25321 [details] New test + result
Darin Adler
Comment 2 2008-11-20 11:52:02 PST
Comment on attachment 25321 [details] New test + result r=me It's a little sad to have these one-off tests when they could easily be changed to have more coverage. It makes our test suite run a lot faster when individual tests can test more than one closely-related thing.
Pam Greene (IRC:pamg)
Comment 3 2008-11-20 13:52:39 PST
Created attachment 25323 [details] Better new test, checks function-style getter too Combining the next one on my list with this one, and using the JS wrapper. Sorry for the wasted previous review.
Pam Greene (IRC:pamg)
Comment 4 2008-11-20 13:53:28 PST
Comment on attachment 25321 [details] New test + result Clearing r+ on obsolete patch.
Darin Adler
Comment 5 2008-11-20 14:07:12 PST
Comment on attachment 25323 [details] Better new test, checks function-style getter too r=me
Pam Greene (IRC:pamg)
Comment 6 2008-11-20 15:20:24 PST
Landed in r38633.
Note You need to log in before you can comment on or make changes to this bug.