WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
223851
Enable "hanging" and "each-line" keywords for the text-indent CSS property
https://bugs.webkit.org/show_bug.cgi?id=223851
Summary
Enable "hanging" and "each-line" keywords for the text-indent CSS property
Antoine Quint
Reported
2021-03-28 03:36:54 PDT
Enable "hanging" and "each-line" keywords for the text-indent CSS property
Attachments
Patch
(60.52 KB, patch)
2021-03-28 03:49 PDT
,
Antoine Quint
no flags
Details
Formatted Diff
Diff
Patch
(59.05 KB, patch)
2021-03-29 09:36 PDT
,
Antoine Quint
no flags
Details
Formatted Diff
Diff
Patch
(22.95 KB, patch)
2021-03-29 10:56 PDT
,
Antoine Quint
koivisto
: review+
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Antoine Quint
Comment 1
2021-03-28 03:39:06 PDT
The text-indent property has "hanging" and "each-line" keywords which we have code for behind the ENABLE_CSS3_TEXT flag. Chrome exposes them to the Web, and we have good support for it in WebKit that ought to be enabled.
Antoine Quint
Comment 2
2021-03-28 03:49:12 PDT
Created
attachment 424490
[details]
Patch
Antti Koivisto
Comment 3
2021-03-28 12:32:02 PDT
Comment on
attachment 424490
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=424490&action=review
> Source/WebCore/ChangeLog:13 > + But LineWidth.cpp already knew how to handle these keywords, so there seems to be no reason to keep > + these behind a flag.
Is Alan ok with enabling this feature?
Antoine Quint
Comment 4
2021-03-29 09:36:40 PDT
Created
attachment 424537
[details]
Patch
Antoine Quint
Comment 5
2021-03-29 10:56:07 PDT
Created
attachment 424548
[details]
Patch
Antoine Quint
Comment 6
2021-03-30 00:41:00 PDT
Committed
r275199
(
235896@main
): <
https://commits.webkit.org/235896@main
>
Radar WebKit Bug Importer
Comment 7
2021-03-30 00:41:13 PDT
<
rdar://problem/75993897
>
Kiet Ho
Comment 8
2022-05-19 16:47:17 PDT
***
Bug 112755
has been marked as a duplicate of this bug. ***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug