RESOLVED FIXED 223849
[GPU Process] Simplify DisplayList::Iterator part 1: Require encoding/decoding delegates for non-inline display list items
https://bugs.webkit.org/show_bug.cgi?id=223849
Summary [GPU Process] Simplify DisplayList::Iterator part 1: Require encoding/decodin...
Myles C. Maxfield
Reported 2021-03-28 01:37:12 PDT
[GPU Process] Simplify DisplayList::Iterator part 1: Require encoding/decoding delegates for non-inline display list items
Attachments
Patch (34.60 KB, patch)
2021-03-28 01:49 PDT, Myles C. Maxfield
no flags
Patch (45.52 KB, patch)
2021-03-28 13:46 PDT, Myles C. Maxfield
no flags
Patch (46.11 KB, patch)
2021-03-28 20:01 PDT, Myles C. Maxfield
no flags
Patch (46.51 KB, patch)
2021-03-28 22:20 PDT, Myles C. Maxfield
no flags
Patch (46.42 KB, patch)
2021-03-28 23:30 PDT, Myles C. Maxfield
wenson_hsieh: review+
Patch for committing (46.27 KB, patch)
2021-04-02 14:48 PDT, Myles C. Maxfield
no flags
Myles C. Maxfield
Comment 1 2021-03-28 01:49:16 PDT
Myles C. Maxfield
Comment 2 2021-03-28 13:46:03 PDT
Myles C. Maxfield
Comment 3 2021-03-28 20:01:36 PDT
Wenson Hsieh
Comment 4 2021-03-28 22:08:59 PDT
Comment on attachment 424519 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424519&action=review > Source/WebCore/html/HTMLCanvasElement.cpp:49 > +#include "InMemoryDisplayList.h" Do we need this include? > Source/WebCore/platform/graphics/displaylists/InMemoryDisplayList.cpp:64 > + for (auto iterator = this->begin(); iterator != end; ++iterator) { Can we just do something like `for (auto [item, extent, size] : *this) { …` here instead? > Source/WebCore/platform/graphics/displaylists/InMemoryDisplayList.h:55 > + std::unique_ptr<ItemBufferWritingClient> m_writingClient; > + std::unique_ptr<ItemBufferReadingClient> m_readingClient; Should these be of type `InMemoryDisplayList::WritingClient` and `InMemoryDisplayList::ReadingClient`? (i.e. do we expect these to be set to non-in-memory clients)?
Myles C. Maxfield
Comment 5 2021-03-28 22:20:57 PDT
Myles C. Maxfield
Comment 6 2021-03-28 23:30:17 PDT
Wenson Hsieh
Comment 7 2021-04-02 08:22:07 PDT
Comment on attachment 424527 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424527&action=review > Source/WebCore/platform/graphics/displaylists/DisplayListImageBuffer.h:59 > + m_drawingContext.displayList().setItemBufferClient(m_writingClient.get()); > + m_drawingContext.displayList().setItemBufferClient(m_readingClient.get()); It looks like this needs to be updated after the recent renaming.
Myles C. Maxfield
Comment 8 2021-04-02 14:48:34 PDT
Created attachment 425057 [details] Patch for committing
Radar WebKit Bug Importer
Comment 9 2021-04-04 21:22:44 PDT
EWS
Comment 10 2021-04-05 17:22:08 PDT
Committed r275459: <https://commits.webkit.org/r275459> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425057 [details].
Note You need to log in before you can comment on or make changes to this bug.