Bug 223849 – [GPU Process] Simplify DisplayList::Iterator part 1: Require encoding/decoding delegates for non-inline display list items

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

[GPU Process] Simplify DisplayList::Iterator part 1: Require encoding/decoding delegates for non-inline display list items

[Myles C. Maxfield]

Created attachment 424486 [details]
Patch

[Myles C. Maxfield]

Created attachment 424508 [details]
Patch

[Myles C. Maxfield]

Created attachment 424519 [details]
Patch

[Wenson Hsieh]

Comment on attachment 424519 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424519&action=review

> Source/WebCore/html/HTMLCanvasElement.cpp:49
> +#include "InMemoryDisplayList.h"

Do we need this include?

> Source/WebCore/platform/graphics/displaylists/InMemoryDisplayList.cpp:64
> +    for (auto iterator = this->begin(); iterator != end; ++iterator) {

Can we just do something like `for (auto [item, extent, size] : *this) { …` here instead?

> Source/WebCore/platform/graphics/displaylists/InMemoryDisplayList.h:55
> +    std::unique_ptr<ItemBufferWritingClient> m_writingClient;
> +    std::unique_ptr<ItemBufferReadingClient> m_readingClient;

Should these be of type `InMemoryDisplayList::WritingClient` and `InMemoryDisplayList::ReadingClient`? (i.e. do we expect these to be set to non-in-memory clients)?

[Myles C. Maxfield]

Created attachment 424523 [details]
Patch

[Myles C. Maxfield]

Created attachment 424527 [details]
Patch

[Wenson Hsieh]

Comment on attachment 424527 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424527&action=review

> Source/WebCore/platform/graphics/displaylists/DisplayListImageBuffer.h:59
> +        m_drawingContext.displayList().setItemBufferClient(m_writingClient.get());
> +        m_drawingContext.displayList().setItemBufferClient(m_readingClient.get());

It looks like this needs to be updated after the recent renaming.

[Myles C. Maxfield]

Created attachment 425057 [details]
Patch for committing

[Radar WebKit Bug Importer]

<rdar://problem/76205069>

[EWS]

Committed r275459: <https://commits.webkit.org/r275459>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425057 [details].