Bug 223834 - REGRESSION(r275111) [GLIB] Fix build with new derived sources and forwarding headers scheme
Summary: REGRESSION(r275111) [GLIB] Fix build with new derived sources and forwarding ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lauro Moura
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-26 19:42 PDT by Lauro Moura
Modified: 2021-03-27 06:48 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.77 KB, patch)
2021-03-26 19:44 PDT, Lauro Moura 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lauro Moura 2021-03-26 19:42:46 PDT 
REGRESSION(r271111) [GLIB] Fix build with new derived sources and forwarding headers scheme
Comment 1 Lauro Moura 2021-03-26 19:44:29 PDT 
Created attachment 424434 [details]
Patch
Comment 2 Lauro Moura 2021-03-26 20:10:25 PDT 
Committed r275127 (235832@main): <https://commits.webkit.org/235832@main>
Comment 3 Lauro Moura 2021-03-26 22:13:24 PDT 
Still failing on the bots
Comment 4 Philippe Normand 2021-03-27 03:41:53 PDT 
GTK Broken too:

../../Source/JavaScriptCore/API/glib/JSCVersion.cpp:21:10: fatal error: 'JSCVersion.h' file not found
#include "JSCVersion.h"
         ^~~~~~~~~~~~~~

A full clean build works, somehow. But then an incremental build (even without any local change) breaks this way. I see no generated JSCVersion.h file whatsoever.
Comment 5 Philippe Normand 2021-03-27 03:53:00 PDT 
https://trac.webkit.org/changeset/275132/webkit
Comment 6 Lauro Moura 2021-03-27 06:48:15 PDT 
(In reply to Philippe Normand from comment #5)
> https://trac.webkit.org/changeset/275132/webkit

Builders green. Thanks for the fix!