Bug 223831 - Migrate _WKUserContentExtension and older versions of WKContentRuleList to WKContentRuleList during lookup
Summary: Migrate _WKUserContentExtension and older versions of WKContentRuleList to WK...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-26 17:40 PDT by Alex Christensen
Modified: 2021-03-29 11:13 PDT (History)
6 users (show)

See Also:

Attachments
Patch (41.39 KB, patch)
2021-03-26 17:49 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (41.98 KB, patch)
2021-03-29 09:57 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (41.65 KB, patch)
2021-03-29 10:14 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2021-03-26 17:40:53 PDT 
Migrate _WKUserContentExtension and older versions of WKContentRuleList to WKContentRuleList during lookup
Comment 1 Alex Christensen 2021-03-26 17:49:29 PDT 
Created attachment 424425 [details]
Patch
Comment 2 Alex Christensen 2021-03-29 09:57:55 PDT 
Created attachment 424539 [details]
Patch
Comment 3 EWS Watchlist 2021-03-29 09:59:14 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 4 Alex Christensen 2021-03-29 10:14:22 PDT 
Created attachment 424541 [details]
Patch
Comment 5 Brady Eidson 2021-03-29 10:51:44 PDT 
Comment on attachment 424541 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424541&action=review

> Source/WebKit/UIProcess/API/APIContentRuleListStore.cpp:82
> +// FIXME: Remove legacyFilename in 2022 or 2023 after users have had a chance to run the updating logic.

HAH
Comment 6 EWS 2021-03-29 11:12:29 PDT 
Committed r275166: <https://commits.webkit.org/r275166>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424541 [details].
Comment 7 Radar WebKit Bug Importer 2021-03-29 11:13:13 PDT 
<rdar://problem/75963021>