RESOLVED FIXED223823
WebFeature class fails to copy/retain its instance variables 
https://bugs.webkit.org/show_bug.cgi?id=223823
Summary WebFeature class fails to copy/retain its instance variables
David Kilzer (:ddkilzer)
Reported 2021-03-26 15:56:41 PDT
WebFeature class fails to copy/retain its instance variables despite what its @property declarations state. To fix this, I'm just going to add -copy methods in the init method, and add a -dealloc method that can be deleted when switching to ARC. Using RetainPtr<> for this class seems overkill.
Attachments
Patch v1 (2.41 KB, patch)
2021-03-26 15:58 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2021-03-26 15:58:20 PDT
Created attachment 424412 [details] Patch v1
Sam Weinig
Comment 2 2021-03-26 17:27:04 PDT
Comment on attachment 424412 [details] Patch v1 I think Chris is trying to use RetainPtr everywhere, so we probably should here too, but you don't have to in this patch. I can do so in a follow up.
EWS
Comment 3 2021-03-26 21:47:07 PDT
Committed r275131: <https://commits.webkit.org/r275131> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424412 [details].
Radar WebKit Bug Importer
Comment 4 2021-03-26 21:48:12 PDT
<rdar://problem/75913890>
David Kilzer (:ddkilzer)
Comment 5 2021-03-27 10:00:12 PDT
(In reply to Sam Weinig from comment #2) > Comment on attachment 424412 [details] > Patch v1 > > I think Chris is trying to use RetainPtr everywhere, so we probably should > here too, but you don't have to in this patch. I can do so in a follow up. Those were some speculative fixes to try to resolve some CoreIPC crashes if I remember correctly. I appreciate you offering to follow up on this.
Note You need to log in before you can comment on or make changes to this bug.