RESOLVED FIXED 223822
System installing webkitcorepy can break certain scripts 
https://bugs.webkit.org/show_bug.cgi?id=223822
Summary System installing webkitcorepy can break certain scripts
Jonathan Bedard
Reported 2021-03-26 15:51:22 PDT
This issue happens when webkitcorepy (or webkitscmpy) is installed to the system's Python libraries, and the installed version does not match the version checked in to WebKit. This issue is caused by us doing sys.path.append instead of sys.path.insert(0, ...).
Attachments
Patch (5.42 KB, patch)
2021-03-26 15:59 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-03-26 15:51:58 PDT
<rdar://problem/75905163>
Jonathan Bedard
Comment 2 2021-03-26 15:59:35 PDT
Created attachment 424413 [details] Patch
Alan Coon
Comment 3 2021-03-26 16:09:37 PDT
So the fix was something along the lines of Cmd+F for imports of "webkitcorepy" and then changing the insertion method? rs=me as I'm not sure which files need this change but that logic makes sense to me
Alan Coon
Comment 4 2021-03-26 16:11:19 PDT
Comment on attachment 424413 [details] Patch The services failure looks unrelated
Jonathan Bedard
Comment 5 2021-03-26 16:20:50 PDT
(In reply to Alan Coon from comment #3) > So the fix was something along the lines of Cmd+F for imports of > "webkitcorepy" and then changing the insertion method? > > rs=me as I'm not sure which files need this change but that logic makes > sense to me Actually, I just searched for 'sys.path.appned', that's almost always incorrect, and even if it's not implicated in this bug, it's just going to bite us later.
Jonathan Bedard
Comment 6 2021-03-26 16:47:51 PDT
Committed r275122 (235827@main): <https://commits.webkit.org/235827@main>
Note You need to log in before you can comment on or make changes to this bug.