WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
223819
Fix TypeError: Can't mix strings and bytes in path components in Tools/Scripts/dump-class-layout
https://bugs.webkit.org/show_bug.cgi?id=223819
Summary
Fix TypeError: Can't mix strings and bytes in path components in Tools/Script...
Tyler Wilcock
Reported
2021-03-26 14:09:52 PDT
When running the `dump-class-layout` script, I get this error: $ dump-class-layout -c Release WebCore Pair Traceback (most recent call last): File "/home/twilco/projects/webkit/Tools/Scripts//dump-class-layout", line 88, in <module> main() File "/home/twilco/projects/webkit/Tools/Scripts//dump-class-layout", line 80, in main target_path = os.path.join(build_dir, args.config, args.framework + ".framework", args.framework); File "/usr/lib/python3.9/posixpath.py", line 90, in join genericpath._check_arg_types('join', a, *p) File "/usr/lib/python3.9/genericpath.py", line 155, in _check_arg_types raise TypeError("Can't mix strings and bytes in path components") from None TypeError: Can't mix strings and bytes in path components
Attachments
Patch
(2.45 KB, patch)
2021-03-26 14:15 PDT
,
Tyler Wilcock
no flags
Details
Formatted Diff
Diff
Patch
(2.40 KB, patch)
2021-03-26 16:28 PDT
,
Tyler Wilcock
no flags
Details
Formatted Diff
Diff
Patch
(2.40 KB, patch)
2021-03-26 16:31 PDT
,
Tyler Wilcock
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Tyler Wilcock
Comment 1
2021-03-26 14:15:08 PDT
Created
attachment 424403
[details]
Patch
Jonathan Bedard
Comment 2
2021-03-26 16:13:25 PDT
Comment on
attachment 424403
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=424403&action=review
> Tools/Scripts/dump-class-layout:80 > + target_path = os.path.join(build_dir.decode(), args.config, args.framework + ".framework", args.framework);
I think the right answer here is to fix webkit_build_dir() and do the decode subprocess.check_output, it seems like that function should return a string, not bytes.
Tyler Wilcock
Comment 3
2021-03-26 16:28:11 PDT
Created
attachment 424417
[details]
Patch
Tyler Wilcock
Comment 4
2021-03-26 16:31:36 PDT
Created
attachment 424419
[details]
Patch
EWS
Comment 5
2021-03-26 17:02:18 PDT
Committed
r275123
: <
https://commits.webkit.org/r275123
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 424419
[details]
.
Radar WebKit Bug Importer
Comment 6
2021-03-26 17:03:15 PDT
<
rdar://problem/75907744
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug