Bug 223819 – Fix TypeError: Can't mix strings and bytes in path components in Tools/Scripts/dump-class-layout

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Tyler Wilcock]

When running the `dump-class-layout` script, I get this error:

$ dump-class-layout -c Release WebCore Pair
Traceback (most recent call last):
  File "/home/twilco/projects/webkit/Tools/Scripts//dump-class-layout", line 88, in <module>
    main()
  File "/home/twilco/projects/webkit/Tools/Scripts//dump-class-layout", line 80, in main
    target_path = os.path.join(build_dir, args.config, args.framework + ".framework", args.framework);
  File "/usr/lib/python3.9/posixpath.py", line 90, in join
    genericpath._check_arg_types('join', a, *p)
  File "/usr/lib/python3.9/genericpath.py", line 155, in _check_arg_types
    raise TypeError("Can't mix strings and bytes in path components") from None
TypeError: Can't mix strings and bytes in path components

[Tyler Wilcock]

Created attachment 424403 [details]
Patch

[Jonathan Bedard]

Comment on attachment 424403 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424403&action=review

> Tools/Scripts/dump-class-layout:80
> +        target_path = os.path.join(build_dir.decode(), args.config, args.framework + ".framework", args.framework);

I think the right answer here is to fix webkit_build_dir() and do the decode subprocess.check_output, it seems like that function should return a string, not bytes.

[Tyler Wilcock]

Created attachment 424417 [details]
Patch

[Tyler Wilcock]

Created attachment 424419 [details]
Patch

[EWS]

Committed r275123: <https://commits.webkit.org/r275123>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424419 [details].

[Radar WebKit Bug Importer]

<rdar://problem/75907744>