Bug 223818 - VoiceOver does not echo text insertions and deletions when a contenteditable div has a non editable descendant element with a content editable child
Summary: VoiceOver does not echo text insertions and deletions when a contenteditable ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-26 14:04 PDT by Andres Gonzalez
Modified: 2021-04-08 11:23 PDT (History)
9 users (show)

See Also:

Attachments
Patch (4.98 KB, patch)
2021-03-26 14:23 PDT, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Patch (13.17 KB, patch)
2021-04-07 15:32 PDT, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Patch (13.00 KB, patch)
2021-04-07 17:03 PDT, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Patch (14.38 KB, patch)
2021-04-07 17:16 PDT, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Patch (15.15 KB, patch)
2021-04-08 07:51 PDT, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2021-03-26 14:04:56 PDT 
VoiceOver does not echo text insertions and deletions when a contenteditable div has a non editable descendant element with a content editable child
Comment 1 Radar WebKit Bug Importer 2021-03-26 14:05:04 PDT 
<rdar://problem/75900717>
Comment 2 Andres Gonzalez 2021-03-26 14:23:30 PDT 
Created attachment 424404 [details]
Patch
Comment 3 chris fleizach 2021-03-26 14:27:19 PDT 
Comment on attachment 424404 [details]
Patch

is there a layout test that can be added?
Comment 4 Andres Gonzalez 2021-04-07 15:32:35 PDT 
Created attachment 425447 [details]
Patch
Comment 5 Andres Gonzalez 2021-04-07 15:33:51 PDT 
(In reply to chris fleizach from comment #3)
> Comment on attachment 424404 [details]
> Patch
> 
> is there a layout test that can be added?

Added layout test.
Comment 6 chris fleizach 2021-04-07 15:34:54 PDT 
Comment on attachment 425447 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425447&action=review

> Source/WebCore/accessibility/AXObjectCache.cpp:994
> +        // FIXME: why walk up the hierarchy of RenderObjects instead of AXObjects?

should we change this to AXObject tree and verify no tests fail?
Comment 7 Andres Gonzalez 2021-04-07 17:03:23 PDT 
Created attachment 425459 [details]
Patch
Comment 8 Andres Gonzalez 2021-04-07 17:04:40 PDT 
(In reply to chris fleizach from comment #6)
> Comment on attachment 425447 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=425447&action=review
> 
> > Source/WebCore/accessibility/AXObjectCache.cpp:994
> > +        // FIXME: why walk up the hierarchy of RenderObjects instead of AXObjects?
> 
> should we change this to AXObject tree and verify no tests fail?

Done.
Comment 9 Andres Gonzalez 2021-04-07 17:16:55 PDT 
Created attachment 425462 [details]
Patch
Comment 10 Andres Gonzalez 2021-04-07 17:18:32 PDT 
(In reply to Andres Gonzalez from comment #9)
> Created attachment 425462 [details]
> Patch

Skip test in Mac-wk1.
Comment 11 Andres Gonzalez 2021-04-08 07:51:14 PDT 
Created attachment 425507 [details]
Patch
Comment 12 Andres Gonzalez 2021-04-08 07:52:28 PDT 
(In reply to Andres Gonzalez from comment #11)
> Created attachment 425507 [details]
> Patch

Skip test in Win.
Comment 13 EWS 2021-04-08 11:23:10 PDT 
Committed r275664 (236300@main): <https://commits.webkit.org/236300@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425507 [details].