Bug 223817 - [GPU process] Enable CFPrefs direct mode
Summary: [GPU process] Enable CFPrefs direct mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-26 13:48 PDT by Per Arne Vollan
Modified: 2021-04-01 10:40 PDT (History)
3 users (show)

See Also:

Attachments
Patch (8.82 KB, patch)
2021-03-26 13:54 PDT, Per Arne Vollan 		bfulgham: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (8.97 KB, patch)
2021-04-01 07:32 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2021-03-26 13:48:40 PDT 
Enable CFPrefs direct mode in the GPU process.
Comment 1 Per Arne Vollan 2021-03-26 13:54:04 PDT 
Created attachment 424401 [details]
Patch
Comment 2 Simon Fraser (smfr) 2021-03-26 14:01:28 PDT 
Do you have any data on the memory impact?
Comment 3 Per Arne Vollan 2021-03-29 09:31:40 PDT 
(In reply to Simon Fraser (smfr) from comment #2)
> Do you have any data on the memory impact?

I am running tests now :)

Thanks for reviewing!
Comment 4 Brent Fulgham 2021-03-31 12:55:26 PDT 
Comment on attachment 424401 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424401&action=review

R=me

> Source/WebKit/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=223817

Radar, please.

> Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:579
> +(allow file-read*

Please add Literal “/Library/Preferences/.GlobalOreferences.plist”, too.

> Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:580
> +    (home-subpath "/Library/Preferences/.GlobalPreferences.plist")

Please add .GlobalPreferences_m.plist’ too.
Comment 5 Per Arne Vollan 2021-04-01 07:32:57 PDT 
Created attachment 424895 [details]
Patch
Comment 6 EWS 2021-04-01 08:16:00 PDT 
commit-queue failed to commit attachment 424895 [details] to WebKit repository. To retry, please set cq+ flag again.
Comment 7 EWS 2021-04-01 10:38:32 PDT 
Committed r275367: <https://commits.webkit.org/r275367>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424895 [details].
Comment 8 Radar WebKit Bug Importer 2021-04-01 10:40:36 PDT 
<rdar://problem/76110432>