Bug 223815 - enable AspectRatioOfImgFromWidthAndHeightEnabled in WebKitLegacy
Summary: enable AspectRatioOfImgFromWidthAndHeightEnabled in WebKitLegacy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Cameron McCormack (:heycam)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-26 13:33 PDT by Cameron McCormack (:heycam)
Modified: 2021-03-28 22:28 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.91 KB, patch)
2021-03-26 14:40 PDT, Cameron McCormack (:heycam)
no flags Details | Formatted Diff | Diff
Patch (3.86 KB, patch)
2021-03-28 19:17 PDT, Cameron McCormack (:heycam)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron McCormack (:heycam) 2021-03-26 13:33:03 PDT
There's no reason this should be enabled in WebKit but not WebKitLegacy.
Comment 1 Cameron McCormack (:heycam) 2021-03-26 14:40:38 PDT
Created attachment 424407 [details]
Patch
Comment 2 EWS 2021-03-27 14:59:12 PDT
ChangeLog entry in Source/WTF/ChangeLog contains OOPS!.
Comment 3 Sam Weinig 2021-03-28 15:08:04 PDT
Comment on attachment 424407 [details]
Patch

Should probably also remove the overrides in DumpRenderTree/TestOptions.cpp as well.
Comment 4 Cameron McCormack (:heycam) 2021-03-28 19:17:12 PDT
Created attachment 424517 [details]
Patch
Comment 5 EWS 2021-03-28 22:27:20 PDT
Committed r275159: <https://commits.webkit.org/r275159>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424517 [details].
Comment 6 Radar WebKit Bug Importer 2021-03-28 22:28:13 PDT
<rdar://problem/75942058>