As far as I can tell, ENABLE_INDEXED_DATABASE_IN_WORKERS is enabled for all ports. It is on for the cocoa ports via PlatformEnableCocoa.h. It is on for the non-cocoa ports via WebKitFeatures.cmake.
Seems like this is also true for ENABLE_INDEXED_DATABASE. Let's do both.
Created attachment 424422 [details] Patch
Created attachment 424423 [details] Patch
This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features.
Created attachment 424432 [details] Patch
Any inspector folk know what's going on with the Windows's build? C:\cygwin\home\buildbot\worker\Windows-EWS\build\Source\WebCore\inspector\agents\InspectorIndexedDBAgent.h(46,84): error C2039: 'IndexedDBBackendDispatcherHandler': is not a member of 'Inspector' (compiling source file C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\DerivedSources\WebCore\unified-sources\UnifiedSource-84c9f43f-2.cpp) [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] C:\cygwin\home\buildbot\worker\Windows-EWS\build\Source\WebCore\inspector\agents\InspectorIndexedDBAgent.h(38): message : see declaration of 'Inspector' (compiling source file C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\DerivedSources\WebCore\unified-sources\UnifiedSource-84c9f43f-2.cpp) [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] C:\cygwin\home\buildbot\worker\Windows-EWS\build\Source\WebCore\inspector\agents\InspectorIndexedDBAgent.h(46,118): error C2504: 'IndexedDBBackendDispatcherHandler': base class undefined (compiling source file C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\DerivedSources\WebCore\unified-sources\UnifiedSource-84c9f43f-2.cpp) [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] C:\cygwin\home\buildbot\worker\Windows-EWS\build\Source\WebCore\inspector\agents\InspectorIndexedDBAgent.h(60,65): error C2065: 'RequestDatabaseNamesCallback': undeclared identifier (compiling source file C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\DerivedSources\WebCore\unified-sources\UnifiedSource-84c9f43f-2.cpp) [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] C:\cygwin\home\buildbot\worker\Windows-EWS\build\Source\WebCore\inspector\agents\InspectorIndexedDBAgent.h(60,61): error C2923: 'WTF::Ref': 'RequestDatabaseNamesCallback' is not a valid template type argument for parameter 'T' (compiling source file C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\DerivedSources\WebCore\unified-sources\UnifiedSource-84c9f43f-2.cpp) [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
(In reply to Sam Weinig from comment #6) > Any inspector folk know what's going on with the Windows's build? > > C:\cygwin\home\buildbot\worker\Windows- > EWS\build\Source\WebCore\inspector\agents\InspectorIndexedDBAgent.h(46,84): > error C2039: 'IndexedDBBackendDispatcherHandler': is not a member of > 'Inspector' (compiling source file > C:\cygwin\home\buildbot\worker\Windows- > EWS\build\WebKitBuild\Release\DerivedSources\WebCore\unified- > sources\UnifiedSource-84c9f43f-2.cpp) > [C:\cygwin\home\buildbot\worker\Windows- > EWS\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] > C:\cygwin\home\buildbot\worker\Windows- > EWS\build\Source\WebCore\inspector\agents\InspectorIndexedDBAgent.h(38): > message : see declaration of 'Inspector' (compiling source file > C:\cygwin\home\buildbot\worker\Windows- > EWS\build\WebKitBuild\Release\DerivedSources\WebCore\unified- > sources\UnifiedSource-84c9f43f-2.cpp) > [C:\cygwin\home\buildbot\worker\Windows- > EWS\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] > C:\cygwin\home\buildbot\worker\Windows- > EWS\build\Source\WebCore\inspector\agents\InspectorIndexedDBAgent.h(46,118): > error C2504: 'IndexedDBBackendDispatcherHandler': base class undefined > (compiling source file > C:\cygwin\home\buildbot\worker\Windows- > EWS\build\WebKitBuild\Release\DerivedSources\WebCore\unified- > sources\UnifiedSource-84c9f43f-2.cpp) > [C:\cygwin\home\buildbot\worker\Windows- > EWS\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] > C:\cygwin\home\buildbot\worker\Windows- > EWS\build\Source\WebCore\inspector\agents\InspectorIndexedDBAgent.h(60,65): > error C2065: 'RequestDatabaseNamesCallback': undeclared identifier > (compiling source file > C:\cygwin\home\buildbot\worker\Windows- > EWS\build\WebKitBuild\Release\DerivedSources\WebCore\unified- > sources\UnifiedSource-84c9f43f-2.cpp) > [C:\cygwin\home\buildbot\worker\Windows- > EWS\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] > C:\cygwin\home\buildbot\worker\Windows- > EWS\build\Source\WebCore\inspector\agents\InspectorIndexedDBAgent.h(60,61): > error C2923: 'WTF::Ref': 'RequestDatabaseNamesCallback' is not a valid > template type argument for parameter 'T' (compiling source file > C:\cygwin\home\buildbot\worker\Windows- > EWS\build\WebKitBuild\Release\DerivedSources\WebCore\unified- > sources\UnifiedSource-84c9f43f-2.cpp) > [C:\cygwin\home\buildbot\worker\Windows- > EWS\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] I have been told this is just to be expected from the Windows port. So please ignore.
Committed r275151: <https://commits.webkit.org/r275151> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424432 [details].
<rdar://problem/75934037>