Bug 223795 – Now Playing content isn't updated when media session's Metadata is modified

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Jean-Yves Avenard [:jya]]

Currently the Now Playing content is updated when the PlatformMediaSessionManager (MediaSessionManagerCocoa) requests from the PlatformMediaSession (MediaElementSession).

The PlatformMediaSession will retrieve the Media Session metadata and then pass it on.

When the Media Session metadata gets updated (like after retrieving the image data), for the PlatformMediaSessionManager to refresh the Now Playing content, the user must interact with the media element (such as seeking, changing the focus of the window, pausing the video etc).

If no such interaction is to occur, then the Now Playing will show stale data.

We need to notify the PlatformMediaSession that the Metadata got updated and refresh the Now Playing content.

Bug 222158 introduced a mechanism to set observer of the Metadata content. We will use it to fix this bug.

[Radar WebKit Bug Importer]

<rdar://problem/75883478>

[Jean-Yves Avenard [:jya]]

Additionally, by implementing the Media Session observer it will allow to set default action when a Media Session handler isn't defined.

[Jean-Yves Avenard [:jya]]

Created attachment 424345 [details]
Patch

[Jean-Yves Avenard [:jya]]

Created attachment 424346 [details]
Patch

[Jean-Yves Avenard [:jya]]

Issue with forward declaration and Optional, changing method prototype to use reference instead

[Jean-Yves Avenard [:jya]]

Created attachment 424347 [details]
Patch

Fix unresolved symbol on TVOS

[Eric Carlson]

Comment on attachment 424345 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424345&action=review

> Source/WebCore/html/MediaElementSession.cpp:213
> +        session->removeObserver(*m_observer);

You could give MediaSessionObserver a pointer to the media session and have it call add/removeObserver automatically

[Jean-Yves Avenard [:jya]]

Created attachment 424521 [details]
Patch

[Eric Carlson]

Comment on attachment 424521 [details]
Patch

I'm afraid this will need to be rebased.

[Jean-Yves Avenard [:jya]]

Created attachment 424611 [details]
Patch

rebase

[Jean-Yves Avenard [:jya]]

Comment on attachment 424611 [details]
Patch

unrelated iPhoto.Framework failure.

[EWS]

Committed r275203: <https://commits.webkit.org/r275203>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424611 [details].