Bug 223758 - [WebIDL] Remove [ImplicitThis] and [CustomProxyToJSObject] extended attributes
Summary: [WebIDL] Remove [ImplicitThis] and [CustomProxyToJSObject] extended attributes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Trivial
Assignee: Alexey Shvayka
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-25 13:01 PDT by Alexey Shvayka
Modified: 2021-05-20 15:25 PDT (History)
28 users (show)

See Also:

Attachments
Patch (139.92 KB, patch)
2021-03-25 13:08 PDT, Alexey Shvayka 		no flags Details | Formatted Diff | Diff
Patch (168.69 KB, patch)
2021-03-27 03:52 PDT, Alexey Shvayka 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (168.69 KB, patch)
2021-03-27 05:10 PDT, Alexey Shvayka 		no flags Details | Formatted Diff | Diff
Patch (80.59 KB, patch)
2021-05-11 00:32 PDT, Alexey Shvayka 		no flags Details | Formatted Diff | Diff
Patch (161.72 KB, patch)
2021-05-17 09:39 PDT, Alexey Shvayka 		no flags Details | Formatted Diff | Diff
Patch for landing (162.11 KB, patch)
2021-05-20 12:46 PDT, Alexey Shvayka 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Shvayka 2021-03-25 13:01:40 PDT Comment hidden (obsolete)
Comment 1 Alexey Shvayka 2021-03-25 13:08:43 PDT Comment hidden (obsolete)
Comment 2 EWS Watchlist 2021-03-25 13:09:43 PDT 
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 3 Alexey Shvayka 2021-03-27 03:52:52 PDT Comment hidden (obsolete)
Comment 4 Alexey Shvayka 2021-03-27 05:10:11 PDT Comment hidden (obsolete)
Comment 5 Radar WebKit Bug Importer 2021-04-01 13:03:17 PDT 
<rdar://problem/76117359>
Comment 6 Alexey Shvayka 2021-05-11 00:32:59 PDT Comment hidden (obsolete)
Comment 7 Alexey Shvayka 2021-05-17 09:39:04 PDT 
Created attachment 428841 [details]
Patch
Comment 8 Sam Weinig 2021-05-17 12:44:58 PDT 
Comment on attachment 428841 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428841&action=review

> Source/WebCore/bindings/js/JSDOMCastThisValue.h:45
> +template<class JSClass>
> +inline JSClass* castThisValue(JSC::JSGlobalObject& lexicalGlobalObject, JSC::JSValue thisValue)

I think the inline is implicit and not needed in cases like this.

> Source/WebCore/bindings/js/JSDOMGlobalObject.h:157
> +template<class JSClass>
> +inline JSClass* toJSDOMGlobalObject(JSC::VM& vm, JSC::JSValue value)

Same comment about inline.
Comment 9 Alexey Shvayka 2021-05-20 12:46:04 PDT 
Created attachment 429207 [details]
Patch for landing

Remove extra 'inline' specifiers and sync now reviewed WPT from upstream.
Comment 10 Alexey Shvayka 2021-05-20 15:25:08 PDT 
Committed r277830 (237976@main): <https://commits.webkit.org/237976@main>