Bug 223752 - Some calls in AuthenticatorPresenterCoordinator::selectAssertionResponse are not yet available for mac
Summary: Some calls in AuthenticatorPresenterCoordinator::selectAssertionResponse are ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kate Cheney
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-25 10:33 PDT by Kate Cheney
Modified: 2021-03-25 15:46 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.80 KB, patch)
2021-03-25 10:33 PDT, Kate Cheney 		no flags Details | Formatted Diff | Diff
Patch (1.97 KB, patch)
2021-03-25 10:38 PDT, Kate Cheney 		no flags Details | Formatted Diff | Diff
Patch (1.21 KB, patch)
2021-03-25 11:08 PDT, Kate Cheney 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kate Cheney 2021-03-25 10:33:08 PDT 
Some calls in AuthenticatorPresenterCoordinator::selectAssertionResponse are not yet available for mac
Comment 1 Kate Cheney 2021-03-25 10:33:19 PDT 
Created attachment 424256 [details]
Patch
Comment 2 Kate Cheney 2021-03-25 10:33:22 PDT 
<rdar://problem/75808515>
Comment 3 Chris Dumez 2021-03-25 10:33:48 PDT 
Comment on attachment 424256 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424256&action=review

> Source/WebKit/ChangeLog:3
> +        Need a short description (OOPS!).

OOPS
Comment 4 Kate Cheney 2021-03-25 10:38:16 PDT 
Created attachment 424257 [details]
Patch
Comment 5 Kate Cheney 2021-03-25 10:39:24 PDT 
(In reply to Chris Dumez from comment #3)
> Comment on attachment 424256 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=424256&action=review
> 
> > Source/WebKit/ChangeLog:3
> > +        Need a short description (OOPS!).
> 
> OOPS

!
Comment 6 Jiewen Tan 2021-03-25 11:02:38 PDT 
Comment on attachment 424257 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424257&action=review

> Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinator.mm:43
> +#if HAVE(ASC_AUTH_UI) && PLATFORM(IOS)

I think it will be better to modify the conditions of enabling HAVE_ASC_AUTH_UI to include the PLATFORM(IOS).
Comment 7 Jiewen Tan 2021-03-25 11:03:52 PDT 
Comment on attachment 424257 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424257&action=review

>> Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinator.mm:43
>> +#if HAVE(ASC_AUTH_UI) && PLATFORM(IOS)
> 
> I think it will be better to modify the conditions of enabling HAVE_ASC_AUTH_UI to include the PLATFORM(IOS).

In PlatformHave.h. Thanks for fixing this issue.
Comment 8 Kate Cheney 2021-03-25 11:08:13 PDT 
Created attachment 424261 [details]
Patch
Comment 9 Kate Cheney 2021-03-25 11:08:33 PDT 
(In reply to Jiewen Tan from comment #6)
> Comment on attachment 424257 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=424257&action=review
> 
> > Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinator.mm:43
> > +#if HAVE(ASC_AUTH_UI) && PLATFORM(IOS)
> 
> I think it will be better to modify the conditions of enabling
> HAVE_ASC_AUTH_UI to include the PLATFORM(IOS).

agreed! New patch posted.
Comment 10 Jiewen Tan 2021-03-25 11:25:37 PDT 
Comment on attachment 424261 [details]
Patch

LGTM. r=me.
Comment 11 EWS 2021-03-25 14:49:38 PDT 
Committed r275062: <https://commits.webkit.org/r275062>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424261 [details].