Some calls in AuthenticatorPresenterCoordinator::selectAssertionResponse are not yet available for mac
Created attachment 424256 [details] Patch
<rdar://problem/75808515>
Comment on attachment 424256 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424256&action=review > Source/WebKit/ChangeLog:3 > + Need a short description (OOPS!). OOPS
Created attachment 424257 [details] Patch
(In reply to Chris Dumez from comment #3) > Comment on attachment 424256 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=424256&action=review > > > Source/WebKit/ChangeLog:3 > > + Need a short description (OOPS!). > > OOPS !
Comment on attachment 424257 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424257&action=review > Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinator.mm:43 > +#if HAVE(ASC_AUTH_UI) && PLATFORM(IOS) I think it will be better to modify the conditions of enabling HAVE_ASC_AUTH_UI to include the PLATFORM(IOS).
Comment on attachment 424257 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424257&action=review >> Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinator.mm:43 >> +#if HAVE(ASC_AUTH_UI) && PLATFORM(IOS) > > I think it will be better to modify the conditions of enabling HAVE_ASC_AUTH_UI to include the PLATFORM(IOS). In PlatformHave.h. Thanks for fixing this issue.
Created attachment 424261 [details] Patch
(In reply to Jiewen Tan from comment #6) > Comment on attachment 424257 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=424257&action=review > > > Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinator.mm:43 > > +#if HAVE(ASC_AUTH_UI) && PLATFORM(IOS) > > I think it will be better to modify the conditions of enabling > HAVE_ASC_AUTH_UI to include the PLATFORM(IOS). agreed! New patch posted.
Comment on attachment 424261 [details] Patch LGTM. r=me.
Committed r275062: <https://commits.webkit.org/r275062> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424261 [details].