Bug 223748 - Address some alignment issues found by UBSan in contentextensions code
Summary: Address some alignment issues found by UBSan in contentextensions code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-25 09:03 PDT by Chris Dumez
Modified: 2021-03-25 14:20 PDT (History)
4 users (show)

See Also:


Attachments
Patch (7.94 KB, patch)
2021-03-25 09:18 PDT, Chris Dumez
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-03-25 09:03:12 PDT
Address some alignment issues found by UBSan in contentextensions code:
- contentextensions/SerializedNFA.h:55:20: runtime error: reference binding to misaligned address 0xnnnnnnnnn for type 'const unsigned long long', which requires 8 byte alignment
- contentextensions/NFAToDFA.cpp:254:29: runtime error: reference binding to misaligned address 0xnnnnnnnnn for type 'const unsigned long long', which requires 8 byte alignment
- contentextensions/DFABytecodeCompiler.cpp:43:5: runtime error: store to misaligned address 0xnnnnnnnnn for type 'unsigned short', which requires 2 byte alignment
Comment 1 Chris Dumez 2021-03-25 09:18:24 PDT
Created attachment 424252 [details]
Patch
Comment 2 EWS 2021-03-25 11:28:37 PDT
commit-queue failed to commit attachment 424252 [details] to WebKit repository. To retry, please set cq+ flag again.
Comment 3 EWS 2021-03-25 11:47:22 PDT
Committed r275049: <https://commits.webkit.org/r275049>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424252 [details].
Comment 4 Radar WebKit Bug Importer 2021-03-25 11:48:16 PDT
<rdar://problem/75846255>