Bug 223728 – WKContentRuleList first-party should include other subdomains of the current registrable domain

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alex Christensen]

WKContentRuleList first-party should include other subdomains of the current registrable domain

[Alex Christensen]

Created attachment 424215 [details]
Patch

[Alex Christensen]

<rdar://problem/71912579>

[John Wilander]

Comment on attachment 424215 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424215&action=review

r=me with a requested change.

> Source/WebCore/loader/ResourceLoadInfo.cpp:131
> +    return RegistrableDomain(mainDocumentURL) != RegistrableDomain(resourceURL);

You should be able to use RegistrableDomain::matches(const URL& url) here which is faster than creating two RegistrableDomain objects.

[Alex Christensen]

Created attachment 424244 [details]
Patch

[John Wilander]

Comment on attachment 424244 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424244&action=review

> Source/WebCore/loader/ResourceLoadInfo.cpp:129
> +    return !RegistrableDomain(mainDocumentURL).matches(resourceURL);

I would have kept the comparison of the two hosts. Something like return !(mainHost == otherHost || RD(mainURL).matches(otherURL)).

[EWS]

Committed r275035: <https://commits.webkit.org/r275035>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424244 [details].