Bug 223720 - Have App Highlights be a Configuration Setting instead of an internal Preference setting.
Summary: Have App Highlights be a Configuration Setting instead of an internal Prefere...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-24 17:09 PDT by Megan Gardner
Modified: 2021-03-25 22:11 PDT (History)
4 users (show)

See Also:

Attachments
Patch (11.65 KB, patch)
2021-03-24 17:30 PDT, Megan Gardner 		no flags Details | Formatted Diff | Diff
Patch (11.46 KB, patch)
2021-03-24 17:40 PDT, Megan Gardner 		no flags Details | Formatted Diff | Diff
Patch (11.45 KB, patch)
2021-03-25 21:11 PDT, Megan Gardner 		no flags Details | Formatted Diff | Diff
Patch for landing (11.45 KB, patch)
2021-03-25 21:29 PDT, Megan Gardner 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2021-03-24 17:09:28 PDT 
Have App Highlights be a Configuration Setting instead of an internal Perferance setting.
Comment 1 Megan Gardner 2021-03-24 17:30:17 PDT 
Created attachment 424206 [details]
Patch
Comment 2 Megan Gardner 2021-03-24 17:40:34 PDT 
Created attachment 424207 [details]
Patch
Comment 3 Tim Horton 2021-03-24 17:53:27 PDT 
Comment on attachment 424207 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424207&action=review

> Source/WTF/Scripts/Preferences/WebPreferences.yaml:258
> +  exposed: [ WebKit ]

I don't... actually know what `exposed` means here. None of the neighbors have it? May Sam can explain.
Comment 4 Megan Gardner 2021-03-25 21:11:32 PDT 
Created attachment 424315 [details]
Patch
Comment 5 Megan Gardner 2021-03-25 21:29:04 PDT 
Created attachment 424316 [details]
Patch for landing
Comment 6 EWS 2021-03-25 22:09:29 PDT 
Committed r275077: <https://commits.webkit.org/r275077>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424316 [details].
Comment 7 Radar WebKit Bug Importer 2021-03-25 22:11:30 PDT 
<rdar://problem/75872189>