WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
223714
Use StaticStringImpl instead of StringImpl::createStaticStringImpl if it is not dynamic string content
https://bugs.webkit.org/show_bug.cgi?id=223714
Summary
Use StaticStringImpl instead of StringImpl::createStaticStringImpl if it is n...
Yusuke Suzuki
Reported
2021-03-24 15:09:58 PDT
Use StaticStringImpl instead of StringImpl::createStaticStringImpl if it is not dynamic string content
Attachments
Patch
(2.43 KB, patch)
2021-03-24 15:11 PDT
,
Yusuke Suzuki
saam
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1
2021-03-24 15:11:30 PDT
Created
attachment 424190
[details]
Patch
Yusuke Suzuki
Comment 2
2021-03-24 19:31:53 PDT
Committed
r275002
(
235740@main
): <
https://commits.webkit.org/235740@main
>
Radar WebKit Bug Importer
Comment 3
2021-03-24 19:32:16 PDT
<
rdar://problem/75818017
>
Darin Adler
Comment 4
2021-03-25 16:23:48 PDT
Comment on
attachment 424190
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=424190&action=review
> Source/WTF/wtf/URL.cpp:858 > +static StaticStringImpl aboutBlankString { "about:blank" };
Why are these outside the functions?
> Source/WTF/wtf/URL.cpp:869 > +static StaticStringImpl aboutSrcDocString { "about:srcdoc" };
Ditto.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug