Bug 22371 – Add a test for accessing form element items by index

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Pam Greene (IRC:pamg)]

This applies to things like radio-button options.

[Pam Greene (IRC:pamg)]

Created attachment 25296 [details]
New test + result

Simple test, but apparently it wasn't directly covered by any others when we noticed the need.

[Darin Adler]

Comment on attachment 25296 [details]
New test + result

Tests like this should be written with the JavaScript test wrapper whenever possible. Also, it's helpful to test more than just the fact that a value is not undefined when testing something like this.

For an example, look at something like fast/dom/HTMLFormElement/elements-not-in-document.html -- tests like that one are more valuable.

r=me

[Pam Greene (IRC:pamg)]

Created attachment 25319 [details]
Test using the JS test wrapper

I'd rather not rewrite all 86 tests to use the wrapper, but only testing against undefined was indeed pretty lame.

[Darin Adler]

Comment on attachment 25319 [details]
Test using the JS test wrapper

I wasn't aware there were 86 tests.

I guess that's the downside of getting review only after writing all the tests. I try to make the comments promptly so they can be dealt with early.

r=me

[Pam Greene (IRC:pamg)]

(In reply to comment #4)
> (From update of attachment 25319 [details] [review])
> I wasn't aware there were 86 tests.

That's a quick grep count; call it +/- 10, with resources and such.

> I guess that's the downside of getting review only after writing all the tests.
> I try to make the comments promptly so they can be dealt with early.

Absolutely, and I certainly appreciate your quick and understanding reviews.

There are several downsides to trying to submit tests that were written by other people for problems that were fixed long ago, but hopefully having the tests at all is still worthwhile.

[Pam Greene (IRC:pamg)]

Landed in r38640.