Give the WebKit client the ability to log info about the media files which was submitted to a web server through an HTMLFormElement.
Created attachment 424169 [details] Patch
Created attachment 424171 [details] Patch
Comment on attachment 424171 [details] Patch Is doing this by extending the C API the right way?
Comment on attachment 424171 [details] Patch Let's not add to the C API. If someone is using the C API that needs to get this new message, they need to migrate to the ObjC API. I'm also not sure if we need to add LogDiagnosticMessageWithDomain. Can one of the other logging methods do?
(In reply to Alex Christensen from comment #4) > Comment on attachment 424171 [details] > Patch > > Let's not add to the C API. If someone is using the C API that needs to get > this new message, they need to migrate to the ObjC API. > I'm also not sure if we need to add LogDiagnosticMessageWithDomain. Can one > of the other logging methods do? Can you give an example which I can follow?
<rdar://problem/75804136>
Created attachment 424196 [details] Patch
Comment on attachment 424196 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424196&action=review > Source/WebCore/html/HTMLFormElement.cpp:394 > + diagnosticLoggingClient.logDiagnosticMessageWithDomain(message, "WebKit.media"_s); Where did the domain come from? The capitalization is sort of vaguely weird.
Comment on attachment 424196 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424196&action=review >> Source/WebCore/html/HTMLFormElement.cpp:394 >> + diagnosticLoggingClient.logDiagnosticMessageWithDomain(message, "WebKit.media"_s); > > Where did the domain come from? The capitalization is sort of vaguely weird. It seems like you want to log an integer. Would logDiagnosticMessageWithValue work?
Comment on attachment 424196 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424196&action=review >>> Source/WebCore/html/HTMLFormElement.cpp:394 >>> + diagnosticLoggingClient.logDiagnosticMessageWithDomain(message, "WebKit.media"_s); >> >> Where did the domain come from? The capitalization is sort of vaguely weird. > > It seems like you want to log an integer. Would logDiagnosticMessageWithValue work? Could the domain be an enum instead, and an NS_ENUM at the API layer? It would start out with just one thing in it, but we could add more later.
Comment on attachment 424196 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424196&action=review >>>> Source/WebCore/html/HTMLFormElement.cpp:394 >>>> + diagnosticLoggingClient.logDiagnosticMessageWithDomain(message, "WebKit.media"_s); >>> >>> Where did the domain come from? The capitalization is sort of vaguely weird. >> >> It seems like you want to log an integer. Would logDiagnosticMessageWithValue work? > > Could the domain be an enum instead, and an NS_ENUM at the API layer? It would start out with just one thing in it, but we could add more later. I think the enum is a better approach.
Created attachment 424216 [details] Patch
Committed r275103: <https://commits.webkit.org/r275103> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424216 [details].