Bug 223698 - Web Inspector: REGRESSION (r269359): Timelines: TypeError:​ this.deselect is not a function
Summary: Web Inspector: REGRESSION (r269359): Timelines: TypeError:​ this.deselect is ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Razvan Caliman
URL:
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2021-03-24 10:13 PDT by Razvan Caliman
Modified: 2021-03-24 12:31 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.69 KB, patch)
2021-03-24 11:07 PDT, Razvan Caliman 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Razvan Caliman 2021-03-24 10:13:48 PDT 
STR:

- Open WebInspector > Timelines
- Click the "Close" button for any of the sidebar items: Network Requests, Layout & Rendering, JavaScript & Events, CPU
Comment 1 Razvan Caliman 2021-03-24 10:14:39 PDT 
Regressed by https://bugs.webkit.org/show_bug.cgi?id=196956
Comment 2 Radar WebKit Bug Importer 2021-03-24 10:16:04 PDT 
<rdar://problem/75790983>
Comment 3 Razvan Caliman 2021-03-24 11:06:20 PDT 
Error log:

```
TypeError:​ this.deselect is not a function. (In 'this.deselect()​', 'this.deselect' is undefined)​ (at TimelineTreeElement.js:​80:​26)​
    ?​ @ TimelineTreeElement.js:​80:​26
    dispatch @ Object.js:​129:​35
    dispatchEventToListeners @ Object.js:​137:​17
    _clicked @ TreeElementStatusButton.js:​78:​38
    _clicked @ [native code]
```
Comment 4 Razvan Caliman 2021-03-24 11:07:01 PDT 
Created attachment 424160 [details]
Patch
Comment 5 BJ Burg 2021-03-24 11:44:46 PDT 
Comment on attachment 424160 [details]
Patch

r=me
Comment 6 EWS 2021-03-24 12:31:26 PDT 
Committed r274960: <https://commits.webkit.org/r274960>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424160 [details].