Bug 223696 - Source/WebCore/editing/cocoa/HTMLConverter.mm:1278:44: runtime error: member call on null pointer of type 'WebCore::ArchiveResource'
Summary: Source/WebCore/editing/cocoa/HTMLConverter.mm:1278:44: runtime error: member ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-24 09:46 PDT by Chris Dumez
Modified: 2021-03-26 15:42 PDT (History)
7 users (show)

See Also:


Attachments
Patch (2.62 KB, patch)
2021-03-24 09:53 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-03-24 09:46:44 PDT
Address the following bug found by UBSan:
Source/WebCore/editing/cocoa/HTMLConverter.mm:1278:44: runtime error: member call on null pointer of type 'WebCore::ArchiveResource'
Comment 1 Chris Dumez 2021-03-24 09:53:40 PDT
Created attachment 424145 [details]
Patch
Comment 2 Chris Dumez 2021-03-25 11:30:21 PDT
Patch is ready to review.
Comment 3 Alex Christensen 2021-03-26 13:40:28 PDT
Comment on attachment 424145 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424145&action=review

> Source/WebCore/editing/cocoa/HTMLConverter.mm:-1278
> -        const String& mimeType = resource->mimeType();

basically just null checking resource here.
Comment 4 EWS 2021-03-26 13:44:34 PDT
commit-queue failed to commit attachment 424145 [details] to WebKit repository. To retry, please set cq+ flag again.
Comment 5 EWS 2021-03-26 15:41:43 PDT
Committed r275118: <https://commits.webkit.org/r275118>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424145 [details].
Comment 6 Radar WebKit Bug Importer 2021-03-26 15:42:13 PDT
<rdar://problem/75904798>