Bug 223679 - Switch from PORTALLOCATOR_DISABLE_ADAPTER_ENUMERATION to filtering interfaces in Network process
Summary: Switch from PORTALLOCATOR_DISABLE_ADAPTER_ENUMERATION to filtering interfaces...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-24 00:54 PDT by youenn fablet
Modified: 2021-03-25 09:33 PDT (History)
11 users (show)

See Also:

Attachments
Patch (18.45 KB, patch)
2021-03-24 01:10 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (18.54 KB, patch)
2021-03-25 07:17 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (18.53 KB, patch)
2021-03-25 08:26 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (18.53 KB, patch)
2021-03-25 08:27 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2021-03-24 00:54:27 PDT 
Switch from PORTALLOCATOR_DISABLE_ADAPTER_ENUMERATION to filtering interfaces in Network process
Comment 1 youenn fablet 2021-03-24 01:10:53 PDT 
Created attachment 424104 [details]
Patch
Comment 2 youenn fablet 2021-03-24 01:11:21 PDT 
<rdar://70775358>
Comment 3 Eric Carlson 2021-03-24 07:08:15 PDT 
Comment on attachment 424104 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424104&action=review

r=me once the bots are happy

> Source/WebKit/ChangeLog:8
> +        When starting to monitoring, pass whether to enumerate all interfaces from WebProcess to NetworkProcess as a boolean.

s/to monitoring/to monitor/
Comment 4 youenn fablet 2021-03-25 07:17:26 PDT 
Created attachment 424242 [details]
Patch for landing
Comment 5 youenn fablet 2021-03-25 08:26:45 PDT 
Created attachment 424246 [details]
Patch for landing
Comment 6 youenn fablet 2021-03-25 08:27:34 PDT 
Created attachment 424247 [details]
Patch for landing
Comment 7 EWS 2021-03-25 09:33:11 PDT 
Committed r275037: <https://commits.webkit.org/r275037>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424247 [details].