RESOLVED FIXED 223678
[JSC] Rope string equal operation should first check length 
https://bugs.webkit.org/show_bug.cgi?id=223678
Summary [JSC] Rope string equal operation should first check length
Yusuke Suzuki
Reported 2021-03-24 00:52:39 PDT
[JSC] Rope string equal operation should first check length
Attachments
Patch (1.43 KB, patch)
2021-03-24 00:53 PDT, Yusuke Suzuki 		mark.lam: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (2.67 KB, patch)
2021-03-24 01:35 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2021-03-24 00:53:20 PDT
Created attachment 424102 [details] Patch
Mark Lam
Comment 2 2021-03-24 01:04:37 PDT
Comment on attachment 424102 [details] Patch r=me. I’m surprised we aren’t already doing this.
Ryosuke Niwa
Comment 3 2021-03-24 01:09:43 PDT
Comment on attachment 424102 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=424102&action=review > Source/JavaScriptCore/ChangeLog:8 > + This can avoid eagerly resolving rope strings if it is not necessary. lol, this is hilarious!
Yusuke Suzuki
Comment 4 2021-03-24 01:19:07 PDT
stress/redefine-property-same-value-exception-check.js is failing, just because this relies on the fact that this function resolves rope string (and throwing OOM error). We should fix the test.
Yusuke Suzuki
Comment 5 2021-03-24 01:35:27 PDT
Created attachment 424105 [details] Patch
Yusuke Suzuki
Comment 6 2021-03-24 02:54:40 PDT
Failed stress/redefine-property-same-value-exception-check.js test is fixed, and ensured in jsc-armv7-tests result.
Yusuke Suzuki
Comment 7 2021-03-24 02:56:22 PDT
Committed r274935 (235693@main): <https://commits.webkit.org/235693@main>
Radar WebKit Bug Importer
Comment 8 2021-03-24 02:57:13 PDT
<rdar://problem/75777656>
Note You need to log in before you can comment on or make changes to this bug.