Bug 223671 – [GLIB] imported/w3c/web-platform-tests/html/canvas/offscreen/manual/draw-generic-family/2d.text.draw.generic.family.w.html is flaky failing

• Status: RESOLVED
• Resolution: FIXED
• Component: Canvas

[Lauro Moura]

imported/w3c/web-platform-tests/html/canvas/offscreen/manual/draw-generic-family/2d.text.draw.generic.family.w.html

Flakiness in the messages reporting the assertion failures.

Example diff:

--- /home/lauro/dev/WebKit/layout-test-results/imported/w3c/web-platform-tests/html/canvas/offscreen/manual/draw-generic-family/2d.text.draw.generic.family.w-expected.txt
+++ /home/lauro/dev/WebKit/layout-test-results/imported/w3c/web-platform-tests/html/canvas/offscreen/manual/draw-generic-family/2d.text.draw.generic.family.w-actual.txt
@@ -1,10 +1,10 @@
-CONSOLE MESSAGE: Error: assert_array_equals: The image data generated by drawing generic font family 'sans-serif' should be the same for both OffscreenCanvas and regular canvas expected property 11 to be 0 but got 75 (expected array object "0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0" got object "0,0,0,0,0,0,0,0,0,0,75,0,0,0,248,0,0,0,255,0")
-CONSOLE MESSAGE: Error: assert_array_equals: The image data generated by drawing generic font family 'serif' should be the same for both OffscreenCanvas and regular canvas expected property 23 to be 0 but got 7 (expected array object "0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0" got object "0,0,0,0,0,0,0,0,0,0,7,0,0,0,14,0,0,0,1,0")
-CONSOLE MESSAGE: Error: assert_array_equals: The image data generated by drawing generic font family 'cursive' should be the same for both OffscreenCanvas and regular canvas expected property 31 to be 0 but got 5 (expected array object "0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0" got object "0,0,0,0,0,0,0,0,0,0,5,0,0,0,15,0,0,0,3,0")
-CONSOLE MESSAGE: Error: assert_array_equals: The image data generated by drawing generic font family 'fantasy' should be the same for both OffscreenCanvas and regular canvas expected property 15 to be 0 but got 123 (expected array object "0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0" got object "0,0,0,0,0,0,0,0,0,0,123,0,0,0,255,0,0,0,255,0")
-CONSOLE MESSAGE: Error: assert_array_equals: The image data generated by drawing generic font family 'monospace' should be the same for both OffscreenCanvas and regular canvas expected property 7 to be 0 but got 97 (expected array object "0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0" got object "0,0,0,0,0,0,0,97,0,0,0,255,0,0,0,240,0,0,0,98")
+CONSOLE MESSAGE: Error: assert_array_equals: The image data generated by drawing generic font family 'serif' should be the same for both OffscreenCanvas and regular canvas expected property 199 to be 0 but got 126 (expected array object "0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0" got object "0,0,0,0,0,0,0,0,0,0,126,0,0,0,255,0,0,0,255,0")
+CONSOLE MESSAGE: Error: assert_array_equals: The image data generated by drawing generic font family 'fantasy' should be the same for both OffscreenCanvas and regular canvas expected property 15 to be 0 but got 126 (expected array object "0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0" got object "0,0,0,0,0,0,0,0,0,0,126,0,0,0,255,0,0,0,255,0")
+CONSOLE MESSAGE: Error: assert_array_equals: The image data generated by drawing generic font family 'monospace' should be the same for both OffscreenCanvas and regular canvas expected property 7 to be 0 but got 97 (expected array object "0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0" got object "0,0,0,0,0,0,0,97,0,0,0,255,0,0,0,239,0,0,0,65")
+CONSOLE MESSAGE: Error: assert_array_equals: The image data generated by drawing generic font family 'cursive' should be the same for both OffscreenCanvas and regular canvas expected property 371 to be 0 but got 38 (expected array object "0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0" got object "0,0,0,0,0,0,0,0,0,0,38,0,0,0,146,0,0,0,211,0")
+CONSOLE MESSAGE: Error: assert_array_equals: The image data generated by drawing generic font family 'sans-serif' should be the same for both OffscreenCanvas and regular canvas expected property 11 to be 0 but got 53 (expected array object "0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0" got object "0,0,0,0,0,0,0,0,0,0,53,0,0,0,233,0,0,0,255,0")
 
-Harness Error (FAIL), message = Error: assert_array_equals: The image data generated by drawing generic font family 'monospace' should be the same for both OffscreenCanvas and regular canvas expected property 7 to be 0 but got 97 (expected array object "0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0" got object "0,0,0,0,0,0,0,97,0,0,0,255,0,0,0,240,0,0,0,98")
+Harness Error (FAIL), message = Error: assert_array_equals: The image data generated by drawing generic font family 'sans-serif' should be the same for both OffscreenCanvas and regular canvas expected property 11 to be 0 but got 53 (expected array object "0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0" got object "0,0,0,0,0,0,0,0,0,0,53,0,0,0,233,0,0,0,255,0")
 
 TIMEOUT Test that drawing sans-serif produces the same result between canvas and OffscreenCanvas in a Worker Test timed out
 TIMEOUT Test that drawing serif produces the same result between canvas and OffscreenCanvas in a Worker Test timed out
@@ -12,7 +12,7 @@
 TIMEOUT Test that drawing fantasy produces the same result between canvas and OffscreenCanvas in a Worker Test timed out
 TIMEOUT Test that drawing monospace produces the same result between canvas and OffscreenCanvas in a Worker Test timed out
 
-Harness Error (FAIL), message = Error: assert_array_equals: The image data generated by drawing generic font family 'monospace' should be the same for both OffscreenCanvas and regular canvas expected property 7 to be 0 but got 97 (expected array object "0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0" got object "0,0,0,0,0,0,0,97,0,0,0,255,0,0,0,240,0,0,0,98")
+Harness Error (FAIL), message = Error: assert_array_equals: The image data generated by drawing generic font family 'sans-serif' should be the same for both OffscreenCanvas and regular canvas expected property 11 to be 0 but got 53 (expected array object "0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0" got object "0,0,0,0,0,0,0,0,0,0,53,0,0,0,233,0,0,0,255,0")
 
 TIMEOUT Test that drawing sans-serif produces the same result between canvas and OffscreenCanvas in a Worker Test timed out
 TIMEOUT Test that drawing serif produces the same result between canvas and OffscreenCanvas in a Worker Test timed out

[Chris Lord]

I should've checked in the pass expectation and marked this as failing... This is flaky because the failure case is asynchronous and the output can differ. Will address.

[Chris Lord]

Created attachment 424108 [details]
Patch

[EWS]

Committed r274936: <https://commits.webkit.org/r274936>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424108 [details].

[Radar WebKit Bug Importer]

<rdar://problem/75779019>