Bug 223665 - Update CSS Color 5 color-mix() implementation to match the latest draft spec
Summary: Update CSS Color 5 color-mix() implementation to match the latest draft spec
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-23 17:47 PDT by Sam Weinig
Modified: 2021-03-24 10:35 PDT (History)
10 users (show)

See Also:

Attachments
Patch (40.34 KB, patch)
2021-03-23 17:55 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (111.00 KB, patch)
2021-03-23 19:38 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2021-03-23 17:47:58 PDT 
Update CSS Color 5 color-mix() implementation to match the latest draft spec
Comment 1 Sam Weinig 2021-03-23 17:55:11 PDT Comment hidden (obsolete)
Comment 2 Sam Weinig 2021-03-23 19:38:10 PDT 
Created attachment 424093 [details]
Patch
Comment 3 Simon Fraser (smfr) 2021-03-23 19:57:14 PDT 
Comment on attachment 424093 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424093&action=review

> Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:1562
> +    Srgb,
> +    Hsl,
> +    Hwb,
> +    Xyz,
> +    Lab,
> +    Lch

These capitalizations are a bit odd.
Comment 4 EWS 2021-03-24 10:34:55 PDT 
Committed r274947: <https://commits.webkit.org/r274947>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424093 [details].
Comment 5 Radar WebKit Bug Importer 2021-03-24 10:35:17 PDT 
<rdar://problem/75792077>