Bug 223652 - Add IOKit method filter telemetry
Summary: Add IOKit method filter telemetry
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on: 223811 224048 224094
Blocks:
  Show dependency treegraph
 
Reported: 2021-03-23 13:07 PDT by Per Arne Vollan
Modified: 2021-04-02 12:33 PDT (History)
4 users (show)

See Also:


Attachments
Patch (6.70 KB, patch)
2021-03-23 13:15 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff
Patch (8.20 KB, patch)
2021-03-30 14:38 PDT, Per Arne Vollan
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (9.98 KB, patch)
2021-03-31 06:36 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff
Patch (10.31 KB, patch)
2021-03-31 06:42 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff
Patch (11.22 KB, patch)
2021-03-31 07:15 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff
Patch (11.22 KB, patch)
2021-03-31 07:24 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff
Patch (11.46 KB, patch)
2021-03-31 09:33 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff
Patch (13.28 KB, patch)
2021-03-31 12:44 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff
Patch (13.29 KB, patch)
2021-04-01 09:34 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff
Patch (14.51 KB, patch)
2021-04-02 07:38 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2021-03-23 13:07:49 PDT
Add IOKit method filter telemetry in the WebContent sandbox on macOS and iOS.
Comment 1 Radar WebKit Bug Importer 2021-03-23 13:08:09 PDT
<rdar://problem/75751391>
Comment 2 Per Arne Vollan 2021-03-23 13:15:24 PDT
Created attachment 424055 [details]
Patch
Comment 3 Alex Christensen 2021-03-23 13:35:32 PDT
Comment on attachment 424055 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424055&action=review

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:358
> +                        0

Is this a functional change?
Comment 4 Brent Fulgham 2021-03-23 16:24:23 PDT
Comment on attachment 424055 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424055&action=review

r=me

>> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:358
>> +                        0
> 
> Is this a functional change?

Not really -- it just means we are allowing these methods, and collecting telemetry on the others. As opposed to collecting telemetry on all of them.
Comment 5 Per Arne Vollan 2021-03-24 06:59:46 PDT
Comment on attachment 424055 [details]
Patch

Thanks for reviewing!
Comment 6 EWS 2021-03-24 07:28:29 PDT
Committed r274938: <https://commits.webkit.org/r274938>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424055 [details].
Comment 7 WebKit Commit Bot 2021-03-26 12:15:14 PDT
Re-opened since this is blocked by bug 223811
Comment 8 Per Arne Vollan 2021-03-30 14:38:26 PDT
Created attachment 424700 [details]
Patch
Comment 9 Per Arne Vollan 2021-03-31 06:36:47 PDT
Created attachment 424767 [details]
Patch
Comment 10 Per Arne Vollan 2021-03-31 06:42:16 PDT
Created attachment 424768 [details]
Patch
Comment 11 Per Arne Vollan 2021-03-31 07:15:37 PDT
Created attachment 424769 [details]
Patch
Comment 12 Per Arne Vollan 2021-03-31 07:24:08 PDT
Created attachment 424770 [details]
Patch
Comment 13 Per Arne Vollan 2021-03-31 09:33:18 PDT
Created attachment 424778 [details]
Patch
Comment 14 Per Arne Vollan 2021-03-31 12:44:26 PDT
Created attachment 424804 [details]
Patch
Comment 15 Brent Fulgham 2021-03-31 15:33:46 PDT
Comment on attachment 424804 [details]
Patch

r=me
Comment 16 EWS 2021-04-01 03:07:25 PDT
Committed r275350: <https://commits.webkit.org/r275350>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424804 [details].
Comment 17 WebKit Commit Bot 2021-04-01 08:15:30 PDT
Re-opened since this is blocked by bug 224048
Comment 18 Per Arne Vollan 2021-04-01 09:34:47 PDT
Created attachment 424905 [details]
Patch
Comment 19 EWS 2021-04-01 15:20:05 PDT
Committed r275387: <https://commits.webkit.org/r275387>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424905 [details].
Comment 20 WebKit Commit Bot 2021-04-01 22:16:01 PDT
Re-opened since this is blocked by bug 224094
Comment 21 Per Arne Vollan 2021-04-02 07:38:06 PDT
Created attachment 425020 [details]
Patch
Comment 22 EWS 2021-04-02 12:33:21 PDT
Committed r275433: <https://commits.webkit.org/r275433>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425020 [details].