Bug 223649 – Don't require VM_FLAGS_PERMANENT on the simulator builds

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Saam Barati]

...

[Radar WebKit Bug Importer]

<rdar://problem/75747788>

[Saam Barati]

Created attachment 424048 [details]
patch

[Alexey Proskuryakov]

Comment on attachment 424048 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424048&action=review

> Source/WTF/wtf/WTFConfig.cpp:80
> +#if HAVE(VM_FLAGS_PERMANENT) && PLATFORM(IOS_FAMILY_SIMULATOR)

I'd add FIXME: Remove the fallback when the oldest host OS that we support for Simulator has VM_FLAGS_PERMANENT.

> Source/WTF/wtf/WTFConfig.cpp:82
> +            flags = VM_FLAGS_FIXED | VM_FLAGS_OVERWRITE;

It should be safer against potential future code modifications to clear VM_FLAGS_PERMANENT here, not to double-guess what it was set to ten lines above.

[Saam Barati]

Comment on attachment 424048 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424048&action=review

>> Source/WTF/wtf/WTFConfig.cpp:80
>> +#if HAVE(VM_FLAGS_PERMANENT) && PLATFORM(IOS_FAMILY_SIMULATOR)
> 
> I'd add FIXME: Remove the fallback when the oldest host OS that we support for Simulator has VM_FLAGS_PERMANENT.

Sounds good

>> Source/WTF/wtf/WTFConfig.cpp:82
>> +            flags = VM_FLAGS_FIXED | VM_FLAGS_OVERWRITE;
> 
> It should be safer against potential future code modifications to clear VM_FLAGS_PERMANENT here, not to double-guess what it was set to ten lines above.

Sounds good

[Saam Barati]

Created attachment 424054 [details]
patch for landing

[EWS]

Committed r274898: <https://commits.webkit.org/r274898>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424054 [details].