Bug 223647 – Use enum classes and OptionSets for ControlStates::States

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Aditya Keerthi]

...

[Aditya Keerthi]

Created attachment 424383 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 424383 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424383&action=review

> Source/WebCore/platform/ControlStates.h:57
> +        SpinUp = 1 << 8, // Sub-state for HoverState and PressedState.

Should we instead just use { Hovered, Pressed } ?

> Source/WebCore/platform/adwaita/ThemeAdwaita.cpp:262
> +    else if (states.states().contains(ControlStates::States::Hovered))

So much states

[Aditya Keerthi]

(In reply to Simon Fraser (smfr) from comment #2)
> Comment on attachment 424383 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=424383&action=review
> 
> > Source/WebCore/platform/ControlStates.h:57
> > +        SpinUp = 1 << 8, // Sub-state for HoverState and PressedState.
> 
> Should we instead just use { Hovered, Pressed } ?

{ SpinUp } != { Hovered, Pressed }.

From RenderTheme::extractControlStatesForRenderer:

    if (isHovered(o)) {
        states.add(ControlStates::States::Hovered);
        if (isSpinUpButtonPartHovered(o))
            states.add(ControlStates::States::SpinUp);
    }
    if (isPressed(o)) {
        states.add(ControlStates::States::Pressed);
        if (isSpinUpButtonPartPressed(o))
            states.add(ControlStates::States::SpinUp);
    }

[EWS]

Committed r275161: <https://commits.webkit.org/r275161>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424383 [details].

[Radar WebKit Bug Importer]

<rdar://problem/75957697>