Bug 223623 - [Cocoa][Opus] Protect against variable frame duration packets
Summary: [Cocoa][Opus] Protect against variable frame duration packets
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-22 21:50 PDT by Jer Noble
Modified: 2021-03-23 14:27 PDT (History)
7 users (show)

See Also:

Attachments
Patch (13.52 KB, patch)
2021-03-22 21:56 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (13.80 KB, patch)
2021-03-23 09:58 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (13.80 KB, patch)
2021-03-23 10:05 PDT, Jer Noble 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (13.91 KB, patch)
2021-03-23 10:31 PDT, Jer Noble 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (14.07 KB, patch)
2021-03-23 10:40 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2021-03-22 21:50:56 PDT 
[Cocoa][Opus] Protect against variable frame duration packets
Comment 1 Jer Noble 2021-03-22 21:56:22 PDT 
Created attachment 423988 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2021-03-22 21:56:47 PDT 
<rdar://problem/75724080>
Comment 3 Eric Carlson 2021-03-23 08:54:38 PDT 
Comment on attachment 423988 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423988&action=review

r=me once the bots are happy with the patch

> Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp:1307
>  
> +

Nit: an extra blank line snuck in here
Comment 4 Jer Noble 2021-03-23 09:58:52 PDT 
Created attachment 424031 [details]
Patch
Comment 5 Jer Noble 2021-03-23 10:05:43 PDT 
Created attachment 424034 [details]
Patch for landing
Comment 6 Jer Noble 2021-03-23 10:31:28 PDT 
Created attachment 424038 [details]
Patch for landing
Comment 7 Jer Noble 2021-03-23 10:40:28 PDT 
Created attachment 424040 [details]
Patch for landing
Comment 8 EWS 2021-03-23 14:27:49 PDT 
Committed r274902: <https://commits.webkit.org/r274902>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424040 [details].