Bug 223619 - [WinCairo] Implement inspector-resource:// URL scheme handler for Web Inspector resources
Summary: [WinCairo] Implement inspector-resource:// URL scheme handler for Web Inspect...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
: 223566 (view as bug list)
Depends on:
Blocks: 223566
  Show dependency tree / graph
 
Reported: 2021-03-22 18:41 PDT by Fujii Hironori
Modified: 2021-03-25 11:43 PDT (History)
12 users (show)

See Also:

Attachments
Patch (11.18 KB, patch)
2021-03-22 18:48 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Patch (11.22 KB, patch)
2021-03-22 19:00 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2021-03-22 18:41:43 PDT 
[WinCairo] Implement inspector-resource:// URL scheme handler for Web Inspector resources

See also:
  Bug 179904 – [Cocoa] Web Inspector: load inspector resources using a custom scheme handler
Comment 1 Fujii Hironori 2021-03-22 18:48:38 PDT 
Created attachment 423977 [details]
Patch
Comment 2 Fujii Hironori 2021-03-22 19:00:54 PDT 
Created attachment 423978 [details]
Patch
Comment 3 Don Olmstead 2021-03-23 08:31:40 PDT 
Comment on attachment 423978 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423978&action=review

Isn't this going to break inspector on AppleWin?

> Source/WebKit/UIProcess/Inspector/win/InspectorResourceURLSchemeHandler.cpp:47
> +    auto path = URL(adoptCF(CFBundleCopyBundleURL(WebCore::webKitBundle())).get()).fileSystemPath();

This is the only CF related code.

> Source/WebKit/UIProcess/Inspector/win/InspectorResourceURLSchemeHandler.cpp:53
> +        task.didComplete(WebCore::ResourceError::httpError(CURLE_READ_ERROR, requestURL));

This is the only CURL related code.
Comment 4 Fujii Hironori 2021-03-23 12:25:46 PDT 
Comment on attachment 423978 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423978&action=review

>> Source/WebKit/UIProcess/Inspector/win/InspectorResourceURLSchemeHandler.cpp:47
>> +    auto path = URL(adoptCF(CFBundleCopyBundleURL(WebCore::webKitBundle())).get()).fileSystemPath();
> 
> This is the only CF related code.

Yes. It's enclosed #if by USE(CF) && USE(CURL).

>> Source/WebKit/UIProcess/Inspector/win/InspectorResourceURLSchemeHandler.cpp:53
>> +        task.didComplete(WebCore::ResourceError::httpError(CURLE_READ_ERROR, requestURL));
> 
> This is the only CURL related code.

Yes. It's enclosed #if by USE(CF) && USE(CURL).
Comment 5 Fujii Hironori 2021-03-23 12:26:30 PDT 
(In reply to Don Olmstead from comment #3)
> Isn't this going to break inspector on AppleWin?

I don't think so. I didn't change WebKit1.
Comment 6 Fujii Hironori 2021-03-23 17:15:28 PDT 
Comment on attachment 423978 [details]
Patch

Clearing flags on attachment: 423978

Committed r274912 (235682@main): <https://commits.webkit.org/235682@main>
Comment 7 Fujii Hironori 2021-03-23 17:15:33 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2021-03-23 17:16:14 PDT 
<rdar://problem/75762697>
Comment 9 Fujii Hironori 2021-03-23 17:19:05 PDT 
*** Bug 223566 has been marked as a duplicate of this bug. ***
Comment 10 BJ Burg 2021-03-25 11:43:39 PDT 
Thanks for adding this!