Bug 223619 – [WinCairo] Implement inspector-resource:// URL scheme handler for Web Inspector resources

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Fujii Hironori]

[WinCairo] Implement inspector-resource:// URL scheme handler for Web Inspector resources

See also:
  Bug 179904 – [Cocoa] Web Inspector: load inspector resources using a custom scheme handler

[Fujii Hironori]

Created attachment 423977 [details]
Patch

[Fujii Hironori]

Created attachment 423978 [details]
Patch

[Don Olmstead]

Comment on attachment 423978 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423978&action=review

Isn't this going to break inspector on AppleWin?

> Source/WebKit/UIProcess/Inspector/win/InspectorResourceURLSchemeHandler.cpp:47
> +    auto path = URL(adoptCF(CFBundleCopyBundleURL(WebCore::webKitBundle())).get()).fileSystemPath();

This is the only CF related code.

> Source/WebKit/UIProcess/Inspector/win/InspectorResourceURLSchemeHandler.cpp:53
> +        task.didComplete(WebCore::ResourceError::httpError(CURLE_READ_ERROR, requestURL));

This is the only CURL related code.

[Fujii Hironori]

Comment on attachment 423978 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423978&action=review

>> Source/WebKit/UIProcess/Inspector/win/InspectorResourceURLSchemeHandler.cpp:47
>> +    auto path = URL(adoptCF(CFBundleCopyBundleURL(WebCore::webKitBundle())).get()).fileSystemPath();
> 
> This is the only CF related code.

Yes. It's enclosed #if by USE(CF) && USE(CURL).

>> Source/WebKit/UIProcess/Inspector/win/InspectorResourceURLSchemeHandler.cpp:53
>> +        task.didComplete(WebCore::ResourceError::httpError(CURLE_READ_ERROR, requestURL));
> 
> This is the only CURL related code.

Yes. It's enclosed #if by USE(CF) && USE(CURL).

[Fujii Hironori]

(In reply to Don Olmstead from comment #3)
> Isn't this going to break inspector on AppleWin?

I don't think so. I didn't change WebKit1.

[Fujii Hironori]

Comment on attachment 423978 [details]
Patch

Clearing flags on attachment: 423978

Committed r274912 (235682@main): <https://commits.webkit.org/235682@main>

[Fujii Hironori]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/75762697>

[Fujii Hironori]

*** Bug 223566 has been marked as a duplicate of this bug. ***

[Blaze Burg]

Thanks for adding this!