RESOLVED FIXED 223611
[webkitscmpy] Base GitHub mock links on provided remote 
https://bugs.webkit.org/show_bug.cgi?id=223611
Summary [webkitscmpy] Base GitHub mock links on provided remote
Jonathan Bedard
Reported 2021-03-22 16:16:40 PDT
Mock links in GitHub responses should be based on the remote provided.
Attachments
Patch (4.77 KB, patch)
2021-03-22 16:20 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-03-22 16:16:51 PDT
<rdar://problem/75713760>
Jonathan Bedard
Comment 2 2021-03-22 16:20:44 PDT
Created attachment 423958 [details] Patch
Aakash Jain
Comment 3 2021-03-22 16:34:15 PDT
Comment on attachment 423958 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423958&action=review > Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/git_hub.py:211 > + ' <include-fragment src="/{project}/tree-commit/{ref}" aria-label="Loading latest commit">\n' now that project contains complete url (starting from github.example.com), should the src still start with /?
Jonathan Bedard
Comment 4 2021-03-22 16:37:21 PDT
Comment on attachment 423958 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423958&action=review >> Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/git_hub.py:211 >> + ' <include-fragment src="/{project}/tree-commit/{ref}" aria-label="Loading latest commit">\n' > > now that project contains complete url (starting from github.example.com), should the src still start with /? That's why line 229 does "self.remote.split('/')[1:]", we don't want the github.example.com bit, just the team name/repository name
EWS
Comment 5 2021-03-22 17:47:28 PDT
Committed r274830: <https://commits.webkit.org/r274830> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423958 [details].
Note You need to log in before you can comment on or make changes to this bug.