[1961/1979] webkitscmpy.test.svn_unittest.TestRemoteSvn.test_info failed: Traceback (most recent call last): File "/Volumes/gsnedders/projects/Safari/OpenSource/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/svn_unittest.py", line 264, in test_info self.assertDictEqual({ AssertionError: {'Last Changed Author': 'jbedard@apple.com', 'Last Chang[68 chars]: 10} != {'Last Changed Rev': '6', 'Last Changed Author': 'jbedar[68 chars]: 10} {'Last Changed Author': 'jbedard@apple.com', - 'Last Changed Date': '2020-10-02 19:58:20', ? ^ + 'Last Changed Date': '2020-10-02 11:58:20', ? ^ 'Last Changed Rev': '6', 'Revision': 10} Regressed in https://trac.webkit.org/changeset/274366/webkit which changed timezone handling. The fix might just be setting the tz explicitly in that diff to UTC.
Created attachment 423963 [details] Patch
Comment on attachment 423963 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423963&action=review > Tools/ChangeLog:9 > + (GitHub._commit_response): Use utc shifted into PDT for consistency across timezones. Is there any actual advantage to shifting everything to PDT versus just having everything in UTC?
(In reply to Sam Sneddon [:gsnedders] from comment #2) > Comment on attachment 423963 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=423963&action=review > > > Tools/ChangeLog:9 > > + (GitHub._commit_response): Use utc shifted into PDT for consistency across timezones. > > Is there any actual advantage to shifting everything to PDT versus just > having everything in UTC? Mostly because we would need to change unit tests. I would like to revisit this once we've dropped subversion support, because that's the case that's most annoying because the Subversion server vends things in Pacific time
<rdar://problem/75975196>
Created attachment 425285 [details] [fast-cq] Patch
Committed r275604 (236249@main): <https://commits.webkit.org/236249@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425285 [details].