Bug 223605 - dom/WheelEvent.cpp:47:58: runtime error: negation of -2147483648 cannot be represented in type 'int'; cast to an unsigned type to negate this value to itself
Summary: dom/WheelEvent.cpp:47:58: runtime error: negation of -2147483648 cannot be re...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-22 15:06 PDT by Chris Dumez
Modified: 2021-03-23 09:47 PDT (History)
9 users (show)

See Also:

Attachments
Patch (2.54 KB, patch)
2021-03-22 15:07 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (9.76 KB, patch)
2021-03-22 16:13 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (10.16 KB, patch)
2021-03-22 19:48 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-03-22 15:06:13 PDT 
Update WheelEvent constructor to deal with overflow when negating wheelDelta values, instead of having undefined behavior.
Comment 1 Chris Dumez 2021-03-22 15:07:57 PDT 
Created attachment 423944 [details]
Patch
Comment 2 Chris Dumez 2021-03-22 16:13:53 PDT 
Created attachment 423955 [details]
Patch
Comment 3 Chris Dumez 2021-03-22 19:48:01 PDT 
Created attachment 423982 [details]
Patch
Comment 4 EWS 2021-03-23 09:46:19 PDT 
Committed r274876: <https://commits.webkit.org/r274876>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423982 [details].
Comment 5 Radar WebKit Bug Importer 2021-03-23 09:47:15 PDT 
<rdar://problem/75741712>