Bug 223604 - Distinction between m_webPageID and m_identifier in WebPageProxy is extremely unclear
Summary: Distinction between m_webPageID and m_identifier in WebPageProxy is extremely...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-22 15:02 PDT by Sam Weinig
Modified: 2021-03-29 15:03 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2021-03-22 15:02:11 PDT 
WebPageProxy has two identifiers, m_webPageID and m_identifier in WebPageProxy is extremely unclear. There are no comments indicating how these are different, or how they should be used, and the names make them seem identical.

My understanding is that m_webPageID can mutate on process swap, so it should probably have a more clear name, like identifierOfCurrentWebPage, or something like that, and there should be documentation explaining this.
Comment 1 Radar WebKit Bug Importer 2021-03-29 15:03:13 PDT 
<rdar://problem/75975008>