WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
223592
[iPadOS] Stale checked item when reopening <select>
https://bugs.webkit.org/show_bug.cgi?id=223592
Summary
[iPadOS] Stale checked item when reopening <select>
Aditya Keerthi
Reported
2021-03-22 12:31:25 PDT
...
Attachments
Patch
(12.24 KB, patch)
2021-03-22 12:40 PDT
,
Aditya Keerthi
wenson_hsieh
: review+
Details
Formatted Diff
Diff
Patch for landing
(12.22 KB, patch)
2021-03-22 13:19 PDT
,
Aditya Keerthi
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Aditya Keerthi
Comment 1
2021-03-22 12:31:43 PDT
<
rdar://problem/75629529
>
Aditya Keerthi
Comment 2
2021-03-22 12:40:27 PDT
Created
attachment 423920
[details]
Patch
Wenson Hsieh
Comment 3
2021-03-22 13:07:31 PDT
Comment on
attachment 423920
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=423920&action=review
r=mews
> Source/WebKit/UIProcess/ios/forms/WKFormSelectPicker.mm:540 > + option.isSelected = (optionIndex == index);
Nit - I think you can omit the () here.
> LayoutTests/fast/forms/ios/form-control-refresh/select/no-stale-checked-items-in-select-picker.html:35 > + }
Nit - no { } around this if.
Aditya Keerthi
Comment 4
2021-03-22 13:19:39 PDT
Created
attachment 423924
[details]
Patch for landing
Aditya Keerthi
Comment 5
2021-03-22 13:19:59 PDT
Thanks for the review!
EWS
Comment 6
2021-03-23 06:58:34 PDT
Committed
r274866
: <
https://commits.webkit.org/r274866
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 423924
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug