Bug 223592 - [iPadOS] Stale checked item when reopening <select>
Summary: [iPadOS] Stale checked item when reopening <select>
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aditya Keerthi
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-22 12:31 PDT by Aditya Keerthi
Modified: 2021-03-23 06:58 PDT (History)
4 users (show)

See Also:

Attachments
Patch (12.24 KB, patch)
2021-03-22 12:40 PDT, Aditya Keerthi 		wenson_hsieh: review+
Details | Formatted Diff | Diff
Patch for landing (12.22 KB, patch)
2021-03-22 13:19 PDT, Aditya Keerthi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aditya Keerthi 2021-03-22 12:31:25 PDT 
...
Comment 1 Aditya Keerthi 2021-03-22 12:31:43 PDT 
<rdar://problem/75629529>
Comment 2 Aditya Keerthi 2021-03-22 12:40:27 PDT 
Created attachment 423920 [details]
Patch
Comment 3 Wenson Hsieh 2021-03-22 13:07:31 PDT 
Comment on attachment 423920 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423920&action=review

r=mews

> Source/WebKit/UIProcess/ios/forms/WKFormSelectPicker.mm:540
> +        option.isSelected = (optionIndex == index);

Nit - I think you can omit the () here.

> LayoutTests/fast/forms/ios/form-control-refresh/select/no-stale-checked-items-in-select-picker.html:35
> +            }

Nit - no { } around this if.
Comment 4 Aditya Keerthi 2021-03-22 13:19:39 PDT 
Created attachment 423924 [details]
Patch for landing
Comment 5 Aditya Keerthi 2021-03-22 13:19:59 PDT 
Thanks for the review!
Comment 6 EWS 2021-03-23 06:58:34 PDT 
Committed r274866: <https://commits.webkit.org/r274866>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423924 [details].