Bug 223588 - [JSC] JSCustomGetterFunction/JSCustomSetterFunction should use Identifier for their field
Summary: [JSC] JSCustomGetterFunction/JSCustomSetterFunction should use Identifier for...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-22 11:22 PDT by Yusuke Suzuki
Modified: 2021-03-22 16:31 PDT (History)
7 users (show)

See Also:


Attachments
Patch (6.09 KB, patch)
2021-03-22 11:24 PDT, Yusuke Suzuki
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (6.32 KB, patch)
2021-03-22 11:27 PDT, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (9.62 KB, patch)
2021-03-22 12:01 PDT, Yusuke Suzuki
mark.lam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2021-03-22 11:22:50 PDT
[JSC] JSCustomGetterFunction/JSCustomSetterFunction should use Identifier for their field
Comment 1 Yusuke Suzuki 2021-03-22 11:24:37 PDT
Created attachment 423912 [details]
Patch
Comment 2 Yusuke Suzuki 2021-03-22 11:27:24 PDT
Created attachment 423913 [details]
Patch
Comment 3 Mark Lam 2021-03-22 11:55:01 PDT
Comment on attachment 423913 [details]
Patch

r=me
Comment 4 Yusuke Suzuki 2021-03-22 12:01:14 PDT
Created attachment 423915 [details]
Patch
Comment 5 Saam Barati 2021-03-22 12:14:37 PDT
Comment on attachment 423915 [details]
Patch

LGTM too
Comment 6 Yusuke Suzuki 2021-03-22 16:30:35 PDT
Committed r274817 (235615@main): <https://commits.webkit.org/235615@main>
Comment 7 Radar WebKit Bug Importer 2021-03-22 16:31:18 PDT
<rdar://problem/75714374>