RESOLVED FIXED 223579
[webkitscmpy] Allow user to force canonicalization for a specific set of commits 
https://bugs.webkit.org/show_bug.cgi?id=223579
Summary [webkitscmpy] Allow user to force canonicalization for a specific set of commits
Jonathan Bedard
Reported 2021-03-22 09:03:07 PDT
Allow a user to set the number of commits to be canonicalized regardless of the state of the remote.
Attachments
Patch (6.12 KB, patch)
2021-03-22 09:07 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-03-22 09:03:20 PDT
<rdar://problem/75693154>
Jonathan Bedard
Comment 2 2021-03-22 09:07:19 PDT
Created attachment 423894 [details] Patch
Aakash Jain
Comment 3 2021-03-22 11:45:00 PDT
Comment on attachment 423894 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423894&action=review > Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/canonicalize/__init__.py:80 > + difference = args.number difference should be replaced by something which indicate the purpose, e.g.: num_commits_to_canonicalize > Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/canonicalize/__init__.py:81 > + if not args.number: better to use the above variable here in in condition, e.g.: 'if difference'/'if num_commits_to_canonicalize' > Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/canonicalize_unittest.py:213 > + self.assertEqual( can consider formatting it in one line.
Jonathan Bedard
Comment 4 2021-03-22 12:05:04 PDT
Committed r274771 (235580@main): <https://commits.webkit.org/235580@main>
Note You need to log in before you can comment on or make changes to this bug.