Bug 223564 - [GPUP] RemoteAudioSession calls into AVAudioSession when GPUP is enabled, causing hangs
Summary: [GPUP] RemoteAudioSession calls into AVAudioSession when GPUP is enabled, cau...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on: 217535
Blocks:
  Show dependency tree / graph
 
Reported: 2021-03-21 14:14 PDT by Jer Noble
Modified: 2021-05-18 13:59 PDT (History)
9 users (show)

See Also:

Attachments
Patch (42.71 KB, patch)
2021-03-21 14:20 PDT, Jer Noble 		eric.carlson: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (46.95 KB, patch)
2021-03-22 10:08 PDT, Jer Noble 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (47.13 KB, patch)
2021-05-13 12:35 PDT, Jer Noble 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (47.17 KB, patch)
2021-05-18 08:55 PDT, Jer Noble 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (47.22 KB, patch)
2021-05-18 09:18 PDT, Jer Noble 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (47.23 KB, patch)
2021-05-18 09:31 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2021-03-21 14:14:13 PDT 
[GPUP] RemoteAudioSession calls into AVAudioSession when GPUP is enabled, causing hangs
Comment 1 Jer Noble 2021-03-21 14:14:35 PDT 
<rdar://74750291>
Comment 2 Jer Noble 2021-03-21 14:20:17 PDT 
Created attachment 423835 [details]
Patch
Comment 3 Eric Carlson 2021-03-21 20:07:26 PDT 
Comment on attachment 423835 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423835&action=review

> Source/WebCore/platform/audio/ios/AudioSessionIOS.mm:102
> -    m_interruptionObserverHelper = adoptNS([[WebInterruptionObserverHelper alloc] initWithCallback:session]);
> +    m_interruptionObserverHelper = [[WebInterruptionObserverHelper alloc] initWithCallback:this];

Did you mean to drop the `adoptNS`?
Comment 4 Jer Noble 2021-03-22 10:08:09 PDT 
Created attachment 423903 [details]
Patch for landing
Comment 5 Jer Noble 2021-03-23 13:23:53 PDT 
The test failures indicate this patch depends on bug #217535.
Comment 6 Jer Noble 2021-05-13 12:35:00 PDT 
Created attachment 428545 [details]
Patch for landing
Comment 7 EWS 2021-05-17 16:24:09 PDT 
Tools/Scripts/svn-apply failed to apply attachment 428545 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 8 Jer Noble 2021-05-18 08:55:08 PDT 
Created attachment 428943 [details]
Patch for landing
Comment 9 Jer Noble 2021-05-18 09:18:10 PDT 
Created attachment 428945 [details]
Patch for landing
Comment 10 Jer Noble 2021-05-18 09:31:33 PDT 
Created attachment 428947 [details]
Patch for landing
Comment 11 EWS 2021-05-18 13:59:43 PDT 
Committed r277676 (237877@main): <https://commits.webkit.org/237877@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428947 [details].