Bug 223556 - AX: textRectsFromMarkers always fails
Summary: AX: textRectsFromMarkers always fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: chris fleizach
URL:
Keywords: InRadar
Depends on: 223746
Blocks:
  Show dependency tree / graph
 
Reported: 2021-03-20 10:41 PDT by chris fleizach
Modified: 2021-04-02 10:41 PDT (History)
10 users (show)

See Also:

Attachments
patch (5.16 KB, patch)
2021-03-20 10:47 PDT, chris fleizach 		no flags Details | Formatted Diff | Diff
patch (5.50 KB, patch)
2021-03-22 09:17 PDT, chris fleizach 		no flags Details | Formatted Diff | Diff
patch (13.11 KB, patch)
2021-03-25 09:16 PDT, chris fleizach 		no flags Details | Formatted Diff | Diff
patch (13.34 KB, patch)
2021-03-31 00:07 PDT, chris fleizach 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2021-03-20 10:41:34 PDT 
The textRectsFromMarkers:text: method is always failing to return a valid answer because these methods to extend the search range

auto startPosition = visiblePositionForPositionWithOffset(makeContainerOffsetPosition(originalRange.start), -textLength);
auto endPosition = visiblePositionForPositionWithOffset(makeContainerOffsetPosition(originalRange.start), 2 * textLength);

create a range that can't be iterated
Comment 1 chris fleizach 2021-03-20 10:41:49 PDT 
<rdar://74256003>
Comment 2 chris fleizach 2021-03-20 10:47:19 PDT 
Created attachment 423817 [details]
patch
Comment 3 chris fleizach 2021-03-22 09:17:20 PDT 
Created attachment 423895 [details]
patch
Comment 4 EWS 2021-03-22 17:22:06 PDT 
Committed r274826: <https://commits.webkit.org/r274826>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423895 [details].
Comment 5 WebKit Commit Bot 2021-03-25 06:40:31 PDT 
Re-opened since this is blocked by bug 223746
Comment 6 chris fleizach 2021-03-25 09:16:09 PDT 
Created attachment 424250 [details]
patch
Comment 7 chris fleizach 2021-03-31 00:07:10 PDT 
Created attachment 424737 [details]
patch
Comment 8 EWS 2021-04-02 10:41:54 PDT 
Committed r275425: <https://commits.webkit.org/r275425>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424737 [details].