As noted in bug 223467, bad copy/paste/typo there using the wrong promise
Created attachment 423810 [details] Patch
Created attachment 423812 [details] Patch
only updated the changeling for some reasons :(
Created attachment 423813 [details] Patch
Created attachment 423815 [details] Patch
Comment on attachment 423815 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423815&action=review > Source/WebCore/ChangeLog:4 > + Fix typo. > + https://bugs.webkit.org/show_bug.cgi?id=223554 I usually think of typos as a misspelling or other small issue like that. This removes a comment and an #ifdef. Can you explain a bite more about why you are making this change?
(In reply to Sam Weinig from comment #6) > Comment on attachment 423815 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=423815&action=review > > > Source/WebCore/ChangeLog:4 > > + Fix typo. > > + https://bugs.webkit.org/show_bug.cgi?id=223554 > > I usually think of typos as a misspelling or other small issue like that. > This removes a comment and an #ifdef. Can you explain a bite more about why > you are making this change? It was a typo in the original patch. Then this comment was added to point it out and I’m reverting to the original code with the typo fixed.
(In reply to Jean-Yves Avenard [:jya] from comment #7) > (In reply to Sam Weinig from comment #6) > > Comment on attachment 423815 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=423815&action=review > > > > > Source/WebCore/ChangeLog:4 > > > + Fix typo. > > > + https://bugs.webkit.org/show_bug.cgi?id=223554 > > > > I usually think of typos as a misspelling or other small issue like that. > > This removes a comment and an #ifdef. Can you explain a bite more about why > > you are making this change? > > It was a typo in the original patch. Then this comment was added to point it > out and I’m reverting to the original code with the typo fixed. Again, I think of typos as small mistakes like a spelling error. This is a bunch of code, so probably wasn't mis-typed. Either way, please include why this code is changing in the ChangeLog.
(In reply to Sam Weinig from comment #8) > (In reply to Jean-Yves Avenard [:jya] from comment #7) > > (In reply to Sam Weinig from comment #6) > > > Comment on attachment 423815 [details] > > > Patch > > > > > > View in context: > > > https://bugs.webkit.org/attachment.cgi?id=423815&action=review > > > > > > > Source/WebCore/ChangeLog:4 > > > > + Fix typo. > > > > + https://bugs.webkit.org/show_bug.cgi?id=223554 > > > > > > I usually think of typos as a misspelling or other small issue like that. > > > This removes a comment and an #ifdef. Can you explain a bite more about why > > > you are making this change? > > > > It was a typo in the original patch. Then this comment was added to point it > > out and I’m reverting to the original code with the typo fixed. > > Again, I think of typos as small mistakes like a spelling error. This is a > bunch of code, so probably wasn't mis-typed. Either way, please include why > this code is changing in the ChangeLog. Also, given this changes behavior, it should probably have some test change associated with it.
Created attachment 423839 [details] Patch
<rdar://problem/75685432>
Committed r274777: <https://commits.webkit.org/r274777> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423839 [details].