Bug 223554 - Fix typo
Summary: Fix typo
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jean-Yves Avenard [:jya]
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-20 03:50 PDT by Jean-Yves Avenard [:jya]
Modified: 2021-03-22 12:37 PDT (History)
3 users (show)

See Also:


Attachments
Patch (700 bytes, patch)
2021-03-20 03:56 PDT, Jean-Yves Avenard [:jya]
no flags Details | Formatted Diff | Diff
Patch (1.77 KB, patch)
2021-03-20 04:11 PDT, Jean-Yves Avenard [:jya]
no flags Details | Formatted Diff | Diff
Patch (28.18 KB, patch)
2021-03-20 05:09 PDT, Jean-Yves Avenard [:jya]
no flags Details | Formatted Diff | Diff
Patch (1.77 KB, patch)
2021-03-20 05:14 PDT, Jean-Yves Avenard [:jya]
no flags Details | Formatted Diff | Diff
Patch (1.86 KB, patch)
2021-03-21 15:30 PDT, Jean-Yves Avenard [:jya]
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Yves Avenard [:jya] 2021-03-20 03:50:52 PDT
As noted in bug 223467, bad copy/paste/typo there using the wrong promise
Comment 1 Jean-Yves Avenard [:jya] 2021-03-20 03:56:10 PDT
Created attachment 423810 [details]
Patch
Comment 2 Jean-Yves Avenard [:jya] 2021-03-20 04:11:27 PDT
Created attachment 423812 [details]
Patch
Comment 3 Jean-Yves Avenard [:jya] 2021-03-20 04:11:50 PDT
only updated the changeling for some reasons :(
Comment 4 Jean-Yves Avenard [:jya] 2021-03-20 05:09:39 PDT
Created attachment 423813 [details]
Patch
Comment 5 Jean-Yves Avenard [:jya] 2021-03-20 05:14:45 PDT
Created attachment 423815 [details]
Patch
Comment 6 Sam Weinig 2021-03-20 16:39:01 PDT
Comment on attachment 423815 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423815&action=review

> Source/WebCore/ChangeLog:4
> +        Fix typo.
> +        https://bugs.webkit.org/show_bug.cgi?id=223554

I usually think of typos as a misspelling or other small issue like that. This removes a comment and an #ifdef. Can you explain a bite more about why you are making this change?
Comment 7 Jean-Yves Avenard [:jya] 2021-03-20 23:28:00 PDT
(In reply to Sam Weinig from comment #6)
> Comment on attachment 423815 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=423815&action=review
> 
> > Source/WebCore/ChangeLog:4
> > +        Fix typo.
> > +        https://bugs.webkit.org/show_bug.cgi?id=223554
> 
> I usually think of typos as a misspelling or other small issue like that.
> This removes a comment and an #ifdef. Can you explain a bite more about why
> you are making this change?

It was a typo in the original patch. Then this comment was added to point it out and I’m reverting to the original code with the typo fixed.
Comment 8 Sam Weinig 2021-03-21 10:31:26 PDT
(In reply to Jean-Yves Avenard [:jya] from comment #7)
> (In reply to Sam Weinig from comment #6)
> > Comment on attachment 423815 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=423815&action=review
> > 
> > > Source/WebCore/ChangeLog:4
> > > +        Fix typo.
> > > +        https://bugs.webkit.org/show_bug.cgi?id=223554
> > 
> > I usually think of typos as a misspelling or other small issue like that.
> > This removes a comment and an #ifdef. Can you explain a bite more about why
> > you are making this change?
> 
> It was a typo in the original patch. Then this comment was added to point it
> out and I’m reverting to the original code with the typo fixed.

Again, I think of typos as small mistakes like a spelling error. This is a bunch of code, so probably wasn't mis-typed. Either way, please include why this code is changing in the ChangeLog.
Comment 9 Sam Weinig 2021-03-21 10:32:04 PDT
(In reply to Sam Weinig from comment #8)
> (In reply to Jean-Yves Avenard [:jya] from comment #7)
> > (In reply to Sam Weinig from comment #6)
> > > Comment on attachment 423815 [details]
> > > Patch
> > > 
> > > View in context:
> > > https://bugs.webkit.org/attachment.cgi?id=423815&action=review
> > > 
> > > > Source/WebCore/ChangeLog:4
> > > > +        Fix typo.
> > > > +        https://bugs.webkit.org/show_bug.cgi?id=223554
> > > 
> > > I usually think of typos as a misspelling or other small issue like that.
> > > This removes a comment and an #ifdef. Can you explain a bite more about why
> > > you are making this change?
> > 
> > It was a typo in the original patch. Then this comment was added to point it
> > out and I’m reverting to the original code with the typo fixed.
> 
> Again, I think of typos as small mistakes like a spelling error. This is a
> bunch of code, so probably wasn't mis-typed. Either way, please include why
> this code is changing in the ChangeLog.

Also, given this changes behavior, it should probably have some test change associated with it.
Comment 10 Jean-Yves Avenard [:jya] 2021-03-21 15:30:54 PDT
Created attachment 423839 [details]
Patch
Comment 11 Radar WebKit Bug Importer 2021-03-22 04:41:40 PDT
<rdar://problem/75685432>
Comment 12 EWS 2021-03-22 12:37:24 PDT
Committed r274777: <https://commits.webkit.org/r274777>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423839 [details].