Bug 223553 - [JSC] Intl.Locale should not assume is8Bit
Summary: [JSC] Intl.Locale should not assume is8Bit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-20 03:35 PDT by Yusuke Suzuki
Modified: 2021-03-22 13:10 PDT (History)
8 users (show)

See Also:

Attachments
Patch (4.52 KB, patch)
2021-03-20 03:36 PDT, Yusuke Suzuki 		ross.kirsling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2021-03-20 03:35:09 PDT 
[JSC] Intl.Locale should not assume is8Bit
Comment 1 Yusuke Suzuki 2021-03-20 03:36:53 PDT 
Created attachment 423808 [details]
Patch
Comment 2 Ross Kirsling 2021-03-20 17:01:06 PDT 
Comment on attachment 423808 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423808&action=review

r=me. This comes as a shock to me, since we have in fact verified all the characters of these strings by this point. :(

> Source/JavaScriptCore/runtime/IntlLocale.cpp:180
> +    Vector<char, 32> rawValue;
> +    rawValue.resize(value.length() + 1);

Is this different from using the constructor param?
Comment 3 Yusuke Suzuki 2021-03-22 13:05:53 PDT 
Comment on attachment 423808 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423808&action=review

>> Source/JavaScriptCore/runtime/IntlLocale.cpp:180
>> +    rawValue.resize(value.length() + 1);
> 
> Is this different from using the constructor param?

No. Changed :)
Comment 4 Yusuke Suzuki 2021-03-22 13:09:24 PDT 
Committed r274784 (235588@main): <https://commits.webkit.org/235588@main>
Comment 5 Radar WebKit Bug Importer 2021-03-22 13:10:24 PDT 
<rdar://problem/75705456>