Bug 223551 – Web Inspector: rename WebInspectorProxy to WebInspectorUIProxy

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Blaze Burg]

This has bugged me for so long. Might as well fix it.

This makes the -Proxy class have the same prefix as the non-Proxy class.


WebInspectorUI is in WebProcess.
WebInspectorUIProxy is in UIProcess.

[Blaze Burg]

Created attachment 423804 [details]
Patch v1.0

[EWS Watchlist]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Carlos Garcia Campos]

Comment on attachment 423804 [details]
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=423804&action=review

> Source/WebCore/platform/gtk/po/ar.po:1797
> +#: ../../../WebKit2/UIProcess/gtk/WebInspectorUIProxyGtk.cpp:93
> +#: ../../../WebKit2/UIProcess/gtk/WebInspectorUIProxyGtk.cpp:153

Don't worry about these, they don't even exist. They are old comments. Normally, only POTFILES.in needs to be updated, but WebInspectorProxyGtk.cpp doesn't have translatable strings anymore, so it's not even listed in POTFILES.in

[Blaze Burg]

Comment on attachment 423804 [details]
Patch v1.0

Retrying failed GTK EWS builders. I suspect they need a clean build, because Windows is compiling just fine.

[Blaze Burg]

(In reply to Carlos Garcia Campos from comment #3)
> Comment on attachment 423804 [details]
> Patch v1.0
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=423804&action=review
> 
> > Source/WebCore/platform/gtk/po/ar.po:1797
> > +#: ../../../WebKit2/UIProcess/gtk/WebInspectorUIProxyGtk.cpp:93
> > +#: ../../../WebKit2/UIProcess/gtk/WebInspectorUIProxyGtk.cpp:153
> 
> Don't worry about these, they don't even exist. They are old comments.
> Normally, only POTFILES.in needs to be updated, but WebInspectorProxyGtk.cpp
> doesn't have translatable strings anymore, so it's not even listed in
> POTFILES.in

Heh, okay, I'll revert that part. Thanks for the info!

[Don Olmstead]

Comment on attachment 423804 [details]
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=423804&action=review

> Source/WebKit/DerivedSources-input.xcfilelist:107
> -$(PROJECT_DIR)/UIProcess/Inspector/RemoteWebInspectorProxy.messages.in
> -$(PROJECT_DIR)/UIProcess/Inspector/WebInspectorProxy.messages.in
> +$(PROJECT_DIR)/UIProcess/Inspector/RemoteWebInspectorUIProxy.messages.in
> +$(PROJECT_DIR)/UIProcess/Inspector/WebInspectorUIProxy.messages.in

I don't see a corresponding change to the CMakeLists.txt

https://github.com/WebKit/WebKit/blob/main/Source/WebKit/CMakeLists.txt#L205-L206

[Blaze Burg]

Created attachment 423918 [details]
Patch v1.3 - for GTK EWS

[Radar WebKit Bug Importer]

<rdar://problem/75703828>

[Blaze Burg]

Created attachment 423930 [details]
Patch v1.4 - for GTK/Win EWS

[Devin Rousso]

Comment on attachment 423930 [details]
Patch v1.4 - for GTK/Win EWS

rs=me, always wanted to do this :P

View in context: https://bugs.webkit.org/attachment.cgi?id=423804&action=review

>>> Source/WebCore/platform/gtk/po/ar.po:1797
>>> +#: ../../../WebKit2/UIProcess/gtk/WebInspectorUIProxyGtk.cpp:153
>> 
>> Don't worry about these, they don't even exist. They are old comments. Normally, only POTFILES.in needs to be updated, but WebInspectorProxyGtk.cpp doesn't have translatable strings anymore, so it's not even listed in POTFILES.in
> 
> Heh, okay, I'll revert that part. Thanks for the info!

Can we remove these files then (or at least these parts of these files)?

[EWS]

Committed r274815: <https://commits.webkit.org/r274815>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423930 [details].

[Carlos Garcia Campos]

(In reply to Devin Rousso from comment #10)
> Comment on attachment 423930 [details]
> Patch v1.4 - for GTK/Win EWS
> 
> rs=me, always wanted to do this :P
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=423804&action=review
> 
> >>> Source/WebCore/platform/gtk/po/ar.po:1797
> >>> +#: ../../../WebKit2/UIProcess/gtk/WebInspectorUIProxyGtk.cpp:153
> >> 
> >> Don't worry about these, they don't even exist. They are old comments. Normally, only POTFILES.in needs to be updated, but WebInspectorProxyGtk.cpp doesn't have translatable strings anymore, so it's not even listed in POTFILES.in
> > 
> > Heh, okay, I'll revert that part. Thanks for the info!
> 
> Can we remove these files then (or at least these parts of these files)?

No, those are valid translation files. I think those comments are just hints to know where the translatable string come from in the code, but in practice it doesn't really matter if it's part of a different file, the translation will be done in any case.

[Tim Horton]

Comment on attachment 423930 [details]
Patch v1.4 - for GTK/Win EWS

View in context: https://bugs.webkit.org/attachment.cgi?id=423930&action=review

> Source/WebKit/UIProcess/API/C/mac/WKInspectorPrivateMac.h:44
> -WK_EXPORT @interface WKWebInspectorProxyObjCAdapter : NSObject <NSWindowDelegate>
> +WK_EXPORT @interface WKWebInspectorUIProxyObjCAdapter : NSObject <NSWindowDelegate>

I think we need to revert this change, since it breaks SafariForWebKitDevelopment.

[Blaze Burg]

Comment on attachment 423930 [details]
Patch v1.4 - for GTK/Win EWS

View in context: https://bugs.webkit.org/attachment.cgi?id=423930&action=review

>> Source/WebKit/UIProcess/API/C/mac/WKInspectorPrivateMac.h:44
>> +WK_EXPORT @interface WKWebInspectorUIProxyObjCAdapter : NSObject <NSWindowDelegate>
> 
> I think we need to revert this change, since it breaks SafariForWebKitDevelopment.

Alternative approach, define WKWebInspectorProxyObjCAdapter as a subclass of WKWebInpectorUIProxyObjCAdapter with nothing extra, and export it?

[Tim Horton]

(In reply to BJ Burg from comment #14)
> Comment on attachment 423930 [details]
> Patch v1.4 - for GTK/Win EWS
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=423930&action=review
> 
> >> Source/WebKit/UIProcess/API/C/mac/WKInspectorPrivateMac.h:44
> >> +WK_EXPORT @interface WKWebInspectorUIProxyObjCAdapter : NSObject <NSWindowDelegate>
> > 
> > I think we need to revert this change, since it breaks SafariForWebKitDevelopment.
> 
> Alternative approach, define WKWebInspectorProxyObjCAdapter as a subclass of
> WKWebInpectorUIProxyObjCAdapter with nothing extra, and export it?

r=me :)

[Alex Christensen]

r277678