RESOLVED FIXED 223547
Provide a way to specify platform vs security key when requesting an assertion in the SPI 
https://bugs.webkit.org/show_bug.cgi?id=223547
Summary Provide a way to specify platform vs security key when requesting an assertio...
Jiewen Tan
Reported 2021-03-19 17:56:17 PDT
Provide a way to specify platform vs security key when requesting an assertion in the SPI.
Attachments
Patch (50.81 KB, patch)
2021-03-19 18:46 PDT, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Patch (41.56 KB, patch)
2021-03-22 17:01 PDT, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Patch (42.23 KB, patch)
2021-03-23 01:02 PDT, Jiewen Tan 		bfulgham: review+
bfulgham: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (41.99 KB, patch)
2021-03-23 12:11 PDT, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jiewen Tan
Comment 1 2021-03-19 17:56:34 PDT
rdar://74034746
Jiewen Tan
Comment 2 2021-03-19 18:46:10 PDT
Created attachment 423799 [details] Patch
Jiewen Tan
Comment 3 2021-03-22 17:01:01 PDT
Created attachment 423962 [details] Patch
Jiewen Tan
Comment 4 2021-03-23 01:02:41 PDT
Created attachment 423994 [details] Patch
Brent Fulgham
Comment 5 2021-03-23 10:38:10 PDT
Comment on attachment 423994 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423994&action=review r=me > Source/WebCore/ChangeLog:5 > + rdar://74034746 nit: <rdar://74034746> > Source/WebCore/ChangeLog:15 > + * Modules/webauthn/AuthenticatorAttachment.idl: Copied from Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialRequestOptions.mm. I would say these two were "Moved from ...." > Source/WebKit/ChangeLog:5 > + rdar://74034746 Ditto > Source/WebKit/ChangeLog:12 > + * UIProcess/API/Cocoa/_WKAuthenticatorAttachment.h: Copied from Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialRequestOptions.mm. Ditto "Moved from ..."
Jiewen Tan
Comment 6 2021-03-23 12:08:30 PDT
Comment on attachment 423994 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423994&action=review Thanks Brent for r+ this patch. >> Source/WebCore/ChangeLog:5 >> + rdar://74034746 > > nit: <rdar://74034746> Fixed. >> Source/WebCore/ChangeLog:15 >> + * Modules/webauthn/AuthenticatorAttachment.idl: Copied from Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialRequestOptions.mm. > > I would say these two were "Moved from ...." It was auto-generated. Fixed. >> Source/WebKit/ChangeLog:5 >> + rdar://74034746 > > Ditto Fixed. >> Source/WebKit/ChangeLog:12 >> + * UIProcess/API/Cocoa/_WKAuthenticatorAttachment.h: Copied from Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialRequestOptions.mm. > > Ditto "Moved from ..." Fixed.
Jiewen Tan
Comment 7 2021-03-23 12:11:33 PDT
Created attachment 424047 [details] Patch for landing
EWS
Comment 8 2021-03-23 13:00:56 PDT
Committed r274894: <https://commits.webkit.org/r274894> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424047 [details].
Note You need to log in before you can comment on or make changes to this bug.