Provide a way to specify platform vs security key when requesting an assertion in the SPI.
rdar://74034746
Created attachment 423799 [details] Patch
Created attachment 423962 [details] Patch
Created attachment 423994 [details] Patch
Comment on attachment 423994 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423994&action=review r=me > Source/WebCore/ChangeLog:5 > + rdar://74034746 nit: <rdar://74034746> > Source/WebCore/ChangeLog:15 > + * Modules/webauthn/AuthenticatorAttachment.idl: Copied from Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialRequestOptions.mm. I would say these two were "Moved from ...." > Source/WebKit/ChangeLog:5 > + rdar://74034746 Ditto > Source/WebKit/ChangeLog:12 > + * UIProcess/API/Cocoa/_WKAuthenticatorAttachment.h: Copied from Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialRequestOptions.mm. Ditto "Moved from ..."
Comment on attachment 423994 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423994&action=review Thanks Brent for r+ this patch. >> Source/WebCore/ChangeLog:5 >> + rdar://74034746 > > nit: <rdar://74034746> Fixed. >> Source/WebCore/ChangeLog:15 >> + * Modules/webauthn/AuthenticatorAttachment.idl: Copied from Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialRequestOptions.mm. > > I would say these two were "Moved from ...." It was auto-generated. Fixed. >> Source/WebKit/ChangeLog:5 >> + rdar://74034746 > > Ditto Fixed. >> Source/WebKit/ChangeLog:12 >> + * UIProcess/API/Cocoa/_WKAuthenticatorAttachment.h: Copied from Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialRequestOptions.mm. > > Ditto "Moved from ..." Fixed.
Created attachment 424047 [details] Patch for landing
Committed r274894: <https://commits.webkit.org/r274894> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424047 [details].